fix: Allow to disable current issue timer on redmine page

Author: CrawlerCode

src/background.ts

@@ -19,11 +19,17 @@ const registerContentScript = async () => {
   const settings = await getStorage<Partial<Settings>>("settings", {});
   if (!settings.redmineURL) return;
 
+  // Unregister content script
   await chrome.scripting
     .unregisterContentScripts({
       ids: ["content"],
     })
     .catch(() => undefined);
+
+  // If showCurrentIssueTimer is disabled, do not register content script
+  if (!settings.features?.showCurrentIssueTimer) return;
+
+  // Register content script
   await chrome.scripting.registerContentScripts([
     {
       id: "content",
@@ -35,7 +41,7 @@ const registerContentScript = async () => {
 };
 registerContentScript();
 chrome.runtime.onMessage.addListener((message) => {
-  if (message === "redmine-url-changed") {
+  if (["settings-changed:redmineURL", "settings-changed:showCurrentIssueTimer"].includes(message)) {
     registerContentScript();
   }
 });

src/lang/de.json

@@ -141,6 +141,8 @@
   "settings.features.add-notes.description": "Notizen zu Ticket hinzufügen",
   "settings.features.cache-comments.title": "Kommentare zwischenspeichern",
   "settings.features.cache-comments.description": "Kommentare zwischenspeichern, bis sie übermittelt wurden",
+  "settings.features.show-current-issue-timer.title": "Aktuellen Ticket-Timer anzeigen",
+  "settings.features.show-current-issue-timer.description": "Aktuellen Ticket-Timer auf Redmine Seite anzeigen",
   "settings.style": "Styling",
   "settings.style.display-search-always.title": "Suche immer anzeigen",
   "settings.style.sticky-scroll.title": "Sticky scroll",

src/lang/en.json

@@ -140,6 +140,8 @@
   "settings.features.add-notes.description": "Adding notes to an issue",
   "settings.features.cache-comments.title": "Cache comments",
   "settings.features.cache-comments.description": "Cache comments until they are submitted",
+  "settings.features.show-current-issue-timer.title": "Show current issue timer",
+  "settings.features.show-current-issue-timer.description": "Show current issue timer on Redmine page",
   "settings.style": "Styling",
   "settings.style.display-search-always.title": "Display search always",
   "settings.style.sticky-scroll.title": "Sticky scroll",

src/lang/fr.json

@@ -140,6 +140,8 @@
   "settings.features.add-notes.description": "Ajouter des notes à un ticket",
   "settings.features.cache-comments.title": "Mise en cache des commentaires",
   "settings.features.cache-comments.description": "Mettre en cache les commentaires jusqu'à leur soumission",
+  "settings.features.show-current-issue-timer.title": "Show current issue timer",
+  "settings.features.show-current-issue-timer.description": "Show current issue timer on Redmine page",
   "settings.style": "Style",
   "settings.style.display-search-always.title": "Afficher toujours la recherche",
   "settings.style.sticky-scroll.title": "Défilement fixe",

src/lang/ru.json

@@ -140,6 +140,8 @@
   "settings.features.add-notes.description": "Добавлять примечания в задачи",
   "settings.features.cache-comments.title": "Кеширование комментариев",
   "settings.features.cache-comments.description": "Кешировать комментарии пока они не отправлены",
+  "settings.features.show-current-issue-timer.title": "Show current issue timer",
+  "settings.features.show-current-issue-timer.description": "Show current issue timer on Redmine page",
   "settings.style": "Отображение",
   "settings.style.display-search-always.title": "Display search always",
   "settings.style.sticky-scroll.title": "Закрепить названия проектов при прокрутке списка задач",

src/pages/SettingsPage.tsx

@@ -71,6 +71,7 @@ const SettingsPage = () => {
             }),
             addNotes: Yup.boolean(),
             cacheComments: Yup.boolean(),
+            showCurrentIssueTimer: Yup.boolean(),
           }),
           style: Yup.object({
             displaySearchAlways: Yup.boolean(),
@@ -273,6 +274,13 @@ const SettingsPage = () => {
                       description={formatMessage({ id: "settings.features.cache-comments.description" })}
                       as={CheckBox}
                     />
+                    <Field
+                      type="checkbox"
+                      name="features.showCurrentIssueTimer"
+                      title={formatMessage({ id: "settings.features.show-current-issue-timer.title" })}
+                      description={formatMessage({ id: "settings.features.show-current-issue-timer.description" })}
+                      as={CheckBox}
+                    />
                   </div>
                 </Fieldset>
 

src/provider/SettingsProvider.tsx

@@ -14,6 +14,7 @@ export type Settings = {
     roundingInterval: number;
     cacheComments: boolean;
     addNotes: boolean;
+    showCurrentIssueTimer: boolean;
   };
   style: {
     displaySearchAlways: boolean;
@@ -39,6 +40,7 @@ const defaultSettings: Settings = {
     roundingInterval: 15,
     cacheComments: true,
     addNotes: false,
+    showCurrentIssueTimer: true,
   },
   style: {
     displaySearchAlways: false,
@@ -77,7 +79,10 @@ const SettingsProvider = ({ children }: { children: ReactNode }) => {
         setSettings: (newData: Settings) => {
           setData(newData);
           if (newData.redmineURL !== data.redmineURL) {
-            chrome.runtime.sendMessage("redmine-url-changed");
+            chrome.runtime.sendMessage("settings-changed:redmineURL");
+          }
+          if (newData.features.showCurrentIssueTimer !== data.features.showCurrentIssueTimer) {
+            chrome.runtime.sendMessage("settings-changed:showCurrentIssueTimer");
           }
         },
       }}