From 03eb9607e6696bb3771ea3ff6749253cf22b3801 Mon Sep 17 00:00:00 2001 From: manuka rahul <96047526+rahulpinto19@users.noreply.github.com> Date: Tue, 17 Mar 2026 11:41:41 +0000 Subject: [PATCH 1/3] ci: update link checker report labels (#2749) Change the issue labels for high visibility and quick fixing of the broken links https://github.com/googleapis/genai-toolbox/issues/2669#issuecomment-4027529827 --- .github/workflows/link_checker_report.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link_checker_report.yaml b/.github/workflows/link_checker_report.yaml index 28fc753a68c0..237e56b39cbc 100644 --- a/.github/workflows/link_checker_report.yaml +++ b/.github/workflows/link_checker_report.yaml @@ -60,7 +60,9 @@ jobs: with: title: Link Checker Report content-filepath: full-report.md - labels: report, automated issue, link checker + labels: | + priority: p2 + type: process - name: Display Failure Report # Run this ONLY if the link checker failed From f3da6aa5e23b609a1ac9ecc098bccea02f2388ab Mon Sep 17 00:00:00 2001 From: Twisha Bansal <58483338+twishabansal@users.noreply.github.com> Date: Tue, 17 Mar 2026 19:14:12 +0530 Subject: [PATCH 2/3] fix(skills): improve flag validation and silence unit test output (#2759) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description This PR improves the error handling and validation for the `skills-generate` command and cleans up the unit test execution logs. ## Key Changes: - **Positional Arguments**: Implemented `Args: cobra.NoArgs` to strictly reject any unexpected positional arguments. - **Test Output Cleanup**: Updated the test helper in command_test.go to capture and silence Cobra's usage and error messages during test runs, preventing them from polluting the terminal output. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes # --- cmd/internal/skills/command.go | 1 + cmd/internal/skills/command_test.go | 35 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/cmd/internal/skills/command.go b/cmd/internal/skills/command.go index b6847f3f9789..4e7f28dfe851 100644 --- a/cmd/internal/skills/command.go +++ b/cmd/internal/skills/command.go @@ -48,6 +48,7 @@ func NewCommand(opts *internal.ToolboxOptions) *cobra.Command { cmd.Command = &cobra.Command{ Use: "skills-generate", Short: "Generate skills from tool configurations", + Args: cobra.NoArgs, RunE: func(c *cobra.Command, args []string) error { return run(cmd, opts) }, diff --git a/cmd/internal/skills/command_test.go b/cmd/internal/skills/command_test.go index 4e6b93d8d646..6c239cf2a996 100644 --- a/cmd/internal/skills/command_test.go +++ b/cmd/internal/skills/command_test.go @@ -28,12 +28,19 @@ import ( ) func invokeCommand(args []string) (string, error) { - parentCmd := &cobra.Command{Use: "toolbox"} + parentCmd := &cobra.Command{ + Use: "toolbox", + SilenceUsage: true, + SilenceErrors: true, + } buf := new(bytes.Buffer) opts := internal.NewToolboxOptions(internal.WithIOStreams(buf, buf)) internal.PersistentFlags(parentCmd, opts) + parentCmd.SetOut(buf) + parentCmd.SetErr(buf) + cmd := NewCommand(opts) parentCmd.AddCommand(cmd) parentCmd.SetArgs(args) @@ -193,3 +200,29 @@ func TestGenerateSkill_MissingArguments(t *testing.T) { }) } } + +func TestGenerateSkill_FlagValidation(t *testing.T) { + tests := []struct { + name string + args []string + wantSub string + }{ + { + name: "unexpected positional arg", + args: []string{"skills-generate", "--name", "test", "--description", "test", "extra"}, + wantSub: "unknown command \"extra\"", + }, + } + + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + got, err := invokeCommand(tt.args) + if err == nil { + t.Fatalf("expected error containing %q, but got nil\nOutput: %s", tt.wantSub, got) + } + if !strings.Contains(err.Error(), tt.wantSub) && !strings.Contains(got, tt.wantSub) { + t.Errorf("expected error or output to contain %q\nError: %v\nOutput: %s", tt.wantSub, err, got) + } + }) + } +} From 1528d7c38dfaa30bdecbe59c79ba926fa6d18356 Mon Sep 17 00:00:00 2001 From: Niraj Nandre Date: Tue, 17 Mar 2026 20:21:23 +0530 Subject: [PATCH 3/3] revert(ci): implement conditional sharding logic in integration tests (#2763) Reverts googleapis/genai-toolbox#2692 --- .ci/integration.cloudbuild.yaml | 268 +------------------------------- 1 file changed, 4 insertions(+), 264 deletions(-) diff --git a/.ci/integration.cloudbuild.yaml b/.ci/integration.cloudbuild.yaml index 9f74db525ffd..831511579117 100644 --- a/.ci/integration.cloudbuild.yaml +++ b/.ci/integration.cloudbuild.yaml @@ -94,12 +94,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudsqlpg" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud SQL Postgres tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud SQL Postgres integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud SQL Postgres" \ cloudsqlpg \ @@ -123,12 +117,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "alloydb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: AlloyDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: AlloyDB integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "AlloyDB" \ alloydb \ @@ -153,12 +141,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "alloydbpg" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: AlloyDB Postgres tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: AlloyDB Postgres integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "AlloyDB Postgres" \ alloydbpg \ @@ -184,12 +166,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "alloydbainl" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: AlloyDB AI NL tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: AlloyDB AI NL integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "AlloyDB AI NL" \ alloydbainl \ @@ -207,12 +183,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "alloydbomni" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: AlloyDB Omni tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: AlloyDB Omni integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "AlloyDB Omni" \ alloydbomni \ @@ -234,12 +204,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "bigtable" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Bigtable tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Bigtable integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Bigtable" \ bigtable \ @@ -260,12 +224,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "bigquery" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: BigQuery tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: BigQuery integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "BigQuery" \ bigquery \ @@ -286,12 +244,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudgda" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud Gemini Data Analytics tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud Gemini Data Analytics integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud Gemini Data Analytics" \ cloudgda \ @@ -312,12 +264,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "dataplex" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Dataplex tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Dataplex integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Dataplex" \ dataplex \ @@ -336,12 +282,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "dataform" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Dataform tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Dataform integration tests (Shard: $_DB_SHARD)" apt-get update && apt-get install -y npm && \ npm install -g @dataform/cli && \ .ci/test_with_coverage.sh \ @@ -366,12 +306,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudhealthcare" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud Healthcare API tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud Healthcare API integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud Healthcare API" \ cloudhealthcare \ @@ -391,12 +325,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudloggingadmin" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud Logging Admin tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud Logging Admin integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud Logging Admin" \ cloudloggingadmin \ @@ -419,12 +347,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "postgres" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Postgres tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Postgres integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Postgres" \ postgres \ @@ -445,12 +367,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cockroachdb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: CockroachDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: CockroachDB integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "CockroachDB" \ cockroachdb \ @@ -476,12 +392,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "spanner" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Spanner tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Spanner integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Spanner" \ spanner \ @@ -502,12 +412,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "neo4j" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Neo4j tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Neo4j integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Neo4j" \ neo4j \ @@ -532,12 +436,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudsqlmssql" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud SQL MSSQL tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud SQL MSSQL integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud SQL MSSQL" \ cloudsqlmssql \ @@ -561,12 +459,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudsqlmysql" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud SQL MySQL tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud SQL MySQL integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud SQL MySQL" \ cloudsqlmysql \ @@ -589,12 +481,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "mysql" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: MySQL tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: MySQL integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "MySQL" \ mysql \ @@ -617,17 +503,10 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "mssql" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: MSSQL tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: MSSQL integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "MSSQL" \ mssql \ mssql - # - id: "dgraph" # name: golang:1 @@ -660,16 +539,10 @@ steps: args: - -c - | - if [ "$_DB_SHARD" == "http" ] || [ -z "$_DB_SHARD" ]; then - echo "RUNNING: HTTP integration tests (Shard: $_DB_SHARD)" - .ci/test_with_coverage.sh \ - "HTTP" \ - http \ - http - else - echo "SKIPPING: HTTP tests (Active shard is $_DB_SHARD)" - exit 0 - fi + .ci/test_with_coverage.sh \ + "HTTP" \ + http \ + http - id: "sqlite" name: golang:1 @@ -685,12 +558,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "sqlite" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: SQLite tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: SQLite integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "SQLite" \ sqlite \ @@ -713,12 +580,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "couchbase" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Couchbase tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Couchbase integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Couchbase" \ couchbase \ @@ -738,12 +599,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "redis" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Redis tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Redis integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Redis" \ redis \ @@ -764,12 +619,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "valkey" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Valkey tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Valkey integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Valkey" \ valkey \ @@ -792,12 +641,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "oceanbase" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: OceanBase tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: OceanBase integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "OceanBase" \ oceanbase \ @@ -818,12 +661,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "firestore" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Firestore tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Firestore integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Firestore" \ firestore \ @@ -844,12 +681,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "mongodb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: MongoDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: MongoDB integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "MongoDB" \ mongodb \ @@ -879,12 +710,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "looker" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Looker tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Looker integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Looker" \ looker \ @@ -906,12 +731,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "mindsdb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: MindsDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: MindsDB integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "MindsDB" \ mindsdb \ @@ -930,12 +749,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cloudsql" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cloud SQL Wait for Operation tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cloud SQL Wait for Operation integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cloud SQL Wait for Operation" \ cloudsql \ @@ -958,12 +771,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "tidb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: TiDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: TiDB integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "TiDB" \ tidb \ @@ -986,12 +793,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "firebird" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Firebird tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Firebird integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Firebird" \ firebird \ @@ -1014,12 +815,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "clickhouse" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: ClickHouse tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: ClickHouse integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "ClickHouse" \ clickhouse \ @@ -1043,12 +838,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "trino" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Trino tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Trino integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Trino" \ trino \ @@ -1072,12 +861,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "yugabytedb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: YugabyteDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: YugabyteDB integration tests (Shard: $_DB_SHARD)" ./yugabytedb.test -test.v - id: "elasticsearch" @@ -1094,12 +877,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "elasticsearch" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Elasticsearch tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Elasticsearch integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Elasticsearch" \ elasticsearch \ @@ -1121,12 +898,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "snowflake" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Snowflake tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Snowflake integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Snowflake" \ snowflake \ @@ -1146,12 +917,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "cassandra" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Cassandra tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Cassandra integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Cassandra" \ cassandra \ @@ -1172,13 +937,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "oracle" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Oracle tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Oracle integration tests (Shard: $_DB_SHARD)" - # Install the C compiler and Oracle SDK headers needed for cgo dnf install -y gcc oracle-instantclient-devel # Install Go @@ -1216,12 +974,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "serverlessspark" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: Serverless Spark tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: Serverless Spark integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "Serverless Spark" \ serverlessspark @@ -1263,12 +1015,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "singlestore" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: SingleStore tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: SingleStore integration tests (Shard: $_DB_SHARD)" .ci/test_with_coverage.sh \ "SingleStore" \ singlestore \ @@ -1290,12 +1036,6 @@ steps: args: - -c - | - if [ "$_DB_SHARD" != "mariadb" ] && [ -n "$_DB_SHARD" ]; then - echo "SKIPPING: MariaDB tests (Active shard is $_DB_SHARD)" - exit 0 - fi - - echo "RUNNING: MariaDB integration tests (Shard: $_DB_SHARD)" # skip coverage check as it re-uses current MySQL implementation go test ./tests/mariadb