Skip to content

Commit c6b4512

Browse files
author
OJay Robinson
committed
add _volume property to AbstractPlugin and remove from WebAudioPlugin
1 parent fcc6156 commit c6b4512

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

VERSIONS.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ CRITICAL (may break existing content):
3333
- fix HTMLAudioPlugin.updateStartTime to correct HTMLAudioPlugin._updateStartTime
3434
- added CordovaAudioPlugin, for use with Cordova based apps including PhoneGap and Ionic
3535
- fix Sound.loadComplete throwing errors for src that has not been loaded instead of expected false
36+
- fix missing ._volume property on AbstractPlugin
3637

3738

3839
Version 0.6.0 [December 12, 2014]

src/soundjs/AbstractPlugin.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,15 @@ this.createjs = this.createjs || {};
8080
*/
8181
this._soundInstances = {};
8282

83+
/**
84+
* The internal master volume value of the plugin.
85+
* @property _volume
86+
* @type {Number}
87+
* @default 1
88+
* @protected
89+
*/
90+
this._volume = 1;
91+
8392
/**
8493
* A reference to a loader class used by a plugin that must be set.
8594
* @type {Object}

src/soundjs/webaudio/WebAudioPlugin.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,15 +76,6 @@ this.createjs = this.createjs || {};
7676
*/
7777
this._panningModel = s._panningModel;;
7878

79-
/**
80-
* The internal master volume value of the plugin.
81-
* @property _volume
82-
* @type {Number}
83-
* @default 1
84-
* @protected
85-
*/
86-
this._volume = 1;
87-
8879
/**
8980
* The web audio context, which WebAudio uses to play audio. All nodes that interact with the WebAudioPlugin
9081
* need to be created within this context.

0 commit comments

Comments
 (0)