Skip to content

Commit 80deb73

Browse files
SG-41715: Send internal event on about to show menu (AcademySoftwareFoundation#1065)
### [SG-41715](https://jira.autodesk.com/browse/SG-41715): Send internal event on about to show menu ### Summarize your change. Send an internal event on about to show top menu bar. Note that this fix needs a second PR in the Live Review plugin to fix the issue. ### Describe the reason for the change. A race condition is happening during Live Review sessions that is preventing the menu items to stay blocked while RV is handling graph changes while rebuilding the trop menu bar. To avoid making too much changes to the code at this moment, I proposed a quick fix where we simply make sure to inform the menu is about to be shown so that we can make sure to disable again the required categories. ### Describe what you have tested and on which operating system. The repro steps in the ticket were successfully tested on macOS. Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
1 parent 4d32c1a commit 80deb73

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/lib/app/RvCommon/RvDocument.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1469,6 +1469,7 @@ namespace Rv
14691469

14701470
void RvDocument::aboutToShowMenu()
14711471
{
1472+
session()->userGenericEvent("about-to-show-menu", "");
14721473
if (QMenu* menu = dynamic_cast<QMenu*>(sender()))
14731474
{
14741475
QList<QAction*> actions = menu->actions();

0 commit comments

Comments
 (0)