Skip to content

Tricky Tanks #9814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IThundxr merged 1 commit into from
Jan 11, 2026
Merged

Tricky Tanks #9814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/com/simibubi/create/content/fluids/tank/FluidTankBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,13 @@ public void onPlace(BlockState state, Level world, BlockPos pos, BlockState oldS
if (moved)
return;
withBlockEntityDo(world, pos, FluidTankBlockEntity::updateConnectivity);

// updateConnectivity may have changed the in-world block state, which prevents the call to markAndNotifyBlock
// in net.neoforged.neoforge.common.CommonHooks#onPlaceItemIntoWorld from doing anything
BlockState newState = world.getBlockState(pos);
if (state != newState && newState.getBlock() == this) {
world.markAndNotifyBlock(pos, world.getChunkAt(pos), oldState, newState, UPDATE_ALL_IMMEDIATE, 512);
}
}

@Override
Expand Down