Skip to content

Commit 0ab6fe8

Browse files
properly mark all exported functions as exported
rdar://108675358
1 parent 43cc29a commit 0ab6fe8

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

extensions/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (CMARK_SHARED)
2727

2828
set_target_properties(${LIBRARY} PROPERTIES
2929
OUTPUT_NAME "cmark-gfm-extensions"
30-
DEFINE_SYMBOL "cmark-gfm"
30+
DEFINE_SYMBOL "libcmark_gfm_EXPORTS"
3131
SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.gfm.${PROJECT_VERSION_GFM}
3232
VERSION ${PROJECT_VERSION})
3333

@@ -47,7 +47,6 @@ if (CMARK_STATIC)
4747

4848
set_target_properties(${STATICLIBRARY} PROPERTIES
4949
COMPILE_FLAGS "-DCMARK_GFM_STATIC_DEFINE -DCMARK_GFM_EXTENSIONS_STATIC_DEFINE"
50-
DEFINE_SYMBOL "cmark-gfm"
5150
POSITION_INDEPENDENT_CODE ON)
5251

5352
if (MSVC)

extensions/core-extensions.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ static void register_plugins(void) {
2525
cmark_register_plugin(core_extensions_registration);
2626
}
2727

28+
CMARK_GFM_EXPORT
2829
void cmark_gfm_core_extensions_ensure_registered(void) {
2930
CMARK_RUN_ONCE(registered, register_plugins);
3031
}

extensions/table.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ static cmark_node *try_opening_table_header(cmark_syntax_extension *self,
387387
if (!marker_row) {
388388
return parent_container;
389389
}
390-
390+
391391
assert(marker_row);
392392

393393
cmark_arena_push();
@@ -1029,30 +1029,35 @@ cmark_syntax_extension *create_table_extension(void) {
10291029
return self;
10301030
}
10311031

1032+
CMARK_GFM_EXPORT
10321033
uint16_t cmark_gfm_extensions_get_table_columns(cmark_node *node) {
10331034
if (node->type != CMARK_NODE_TABLE)
10341035
return 0;
10351036

10361037
return ((node_table *)node->as.opaque)->n_columns;
10371038
}
10381039

1040+
CMARK_GFM_EXPORT
10391041
uint8_t *cmark_gfm_extensions_get_table_alignments(cmark_node *node) {
10401042
if (node->type != CMARK_NODE_TABLE)
10411043
return 0;
10421044

10431045
return ((node_table *)node->as.opaque)->alignments;
10441046
}
10451047

1048+
CMARK_GFM_EXPORT
10461049
int cmark_gfm_extensions_set_table_columns(cmark_node *node, uint16_t n_columns) {
10471050
return set_n_table_columns(node, n_columns);
10481051
}
10491052

1053+
CMARK_GFM_EXPORT
10501054
int cmark_gfm_extensions_set_table_alignments(cmark_node *node, uint16_t ncols, uint8_t *alignments) {
10511055
uint8_t *a = (uint8_t *)cmark_node_mem(node)->calloc(1, ncols);
10521056
memcpy(a, alignments, ncols);
10531057
return set_table_alignments(node, a);
10541058
}
10551059

1060+
CMARK_GFM_EXPORT
10561061
int cmark_gfm_extensions_get_table_row_is_header(cmark_node *node)
10571062
{
10581063
if (!node || node->type != CMARK_NODE_TABLE_ROW)
@@ -1061,6 +1066,7 @@ int cmark_gfm_extensions_get_table_row_is_header(cmark_node *node)
10611066
return ((node_table_row *)node->as.opaque)->is_header;
10621067
}
10631068

1069+
CMARK_GFM_EXPORT
10641070
int cmark_gfm_extensions_set_table_row_is_header(cmark_node *node, int is_header)
10651071
{
10661072
if (!node || node->type != CMARK_NODE_TABLE_ROW)
@@ -1070,21 +1076,25 @@ int cmark_gfm_extensions_set_table_row_is_header(cmark_node *node, int is_header
10701076
return 1;
10711077
}
10721078

1079+
CMARK_GFM_EXPORT
10731080
unsigned cmark_gfm_extensions_get_table_cell_colspan(cmark_node *node)
10741081
{
10751082
return get_cell_colspan(node);
10761083
}
10771084

1085+
CMARK_GFM_EXPORT
10781086
unsigned cmark_gfm_extensions_get_table_cell_rowspan(cmark_node *node)
10791087
{
10801088
return get_cell_rowspan(node);
10811089
}
10821090

1091+
CMARK_GFM_EXPORT
10831092
int cmark_gfm_extensions_set_table_cell_colspan(cmark_node *node, unsigned colspan)
10841093
{
10851094
return set_cell_colspan(node, colspan);
10861095
}
10871096

1097+
CMARK_GFM_EXPORT
10881098
int cmark_gfm_extensions_set_table_cell_rowspan(cmark_node *node, unsigned rowspan)
10891099
{
10901100
return set_cell_rowspan(node, rowspan);

extensions/tasklist.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ static const char *get_type_string(cmark_syntax_extension *extension, cmark_node
1818

1919

2020
// Return 1 if state was set, 0 otherwise
21+
CMARK_GFM_EXPORT
2122
int cmark_gfm_extensions_set_tasklist_item_checked(cmark_node *node, bool is_checked) {
2223
// The node has to exist, and be an extension, and actually be the right type in order to get the value.
2324
if (!node || !node->extension || strcmp(cmark_node_get_type_string(node), TYPE_STRING))
@@ -27,6 +28,7 @@ int cmark_gfm_extensions_set_tasklist_item_checked(cmark_node *node, bool is_che
2728
return 1;
2829
}
2930

31+
CMARK_GFM_EXPORT
3032
bool cmark_gfm_extensions_get_tasklist_item_checked(cmark_node *node) {
3133
if (!node || !node->extension || strcmp(cmark_node_get_type_string(node), TYPE_STRING))
3234
return false;

0 commit comments

Comments
 (0)