bug: adding hardware wallet opens new browser window

[JakeUrban]

Hi @earrietadev !

First of all, I'm a big fan of xBull, I just found your wallet by seeing what is out there for Stellar wallet extensions. If you're on Keybase, I'd love to connect.

I added my Stellar account I use with Lobstr to xBull and that worked great. But when I tried to add my Stellar account I used with my Ledger device, I noticed that selecting "Connect Hardware Wallet", it opened up a new browser window. Shouldn't this view remain in the xBull extension? Or if not, why not use the existing chrome window and open a new tab?

[earrietadev]

Hi @JakeUrban!

Glad you like the wallet and yes I'm on Keybase, my username is the same: @earrietadev you can also find me in the Stellar groups (both keybase and discord groups).

About the new window it was designed that way because of Trezor and the ability to pick connected Ledger devices:

• Trezor window: Trezor connection needs to be on a full browser window when interacting with the device (it didn't work with the extension view mode), otherwise it never gets started. This is required for both signing or importing accounts.
• Connected Ledger devices: When first time adding the Ledger device you will need to pick it from the list of connected devices to the computer, at the time I noticed that this popup doesn't appear when using the extension view mode depending on the OS.

So at the time I decided to keep the same behavior for both Ledger and Trezor when adding the account (new browser window when adding a hardware wallet), this way users have similar experience without matter the type of hardware wallet they use and at the same time it gives me bandwidth to add more hardware wallets in the future (in case they also require a similar behavior).

Regarding the reason of using a completely new browser window instead of the one that is already open, to be honest is because doing it this way was easier, we can open and close them without risking closing something we shouldn't (we can say it was so development was easier at the time).

Regards!