refactor: remove StaticJwksDiscovery for cached approach (#149)

Author: john-cremit

crates/nebula-authority/src/main.rs

@@ -5,7 +5,7 @@ use base64::{engine::general_purpose::STANDARD, Engine as _};
 use clap::Parser;
 use domain::authority::Authority;
 use nebula_secret_sharing::shamir::Share;
-use nebula_token::auth::jwks_discovery::{fetch_jwks, CachedRemoteJwksDiscovery, JwksDiscovery, StaticJwksDiscovery};
+use nebula_token::auth::jwks_discovery::{CachedRemoteJwksDiscovery, JwksDiscovery};
 
 use crate::logger::LoggerConfig;
 
@@ -40,9 +40,7 @@ async fn main() -> anyhow::Result<()> {
             CachedRemoteJwksDiscovery::new(app_config.jwks_url.clone(), Duration::from_secs(refresh_interval)).await?,
         )
     } else {
-        let client = reqwest::Client::new();
-        let jwks = fetch_jwks(&client, app_config.jwks_url.clone()).await?;
-        Arc::new(StaticJwksDiscovery::new(jwks))
+        Arc::new(CachedRemoteJwksDiscovery::new(app_config.jwks_url.clone(), Duration::from_secs(600)).await?)
     };
     let application = Application::new(authority, jwks_discovery);
     if let Some(key_shares) = &app_config.disarm_key_shares {

crates/nebula-backbone/src/application/mod.rs

@@ -1,6 +1,6 @@
 use std::{sync::Arc, time::Duration};
 
-use nebula_token::auth::jwks_discovery::{fetch_jwks, CachedRemoteJwksDiscovery, JwksDiscovery, StaticJwksDiscovery};
+use nebula_token::auth::jwks_discovery::{CachedRemoteJwksDiscovery, JwksDiscovery};
 use parameter::{ParameterUseCase, ParameterUseCaseImpl};
 use sea_orm::{DatabaseConnection, TransactionTrait};
 
@@ -123,9 +123,7 @@ pub(super) async fn init(config: &ApplicationConfig) -> anyhow::Result<Applicati
     {
         Arc::new(CachedRemoteJwksDiscovery::new(config.jwks_url.clone(), Duration::from_secs(refresh_interval)).await?)
     } else {
-        let client = reqwest::Client::new();
-        let jwks = fetch_jwks(&client, config.jwks_url.clone()).await?;
-        Arc::new(StaticJwksDiscovery::new(jwks))
+        Arc::new(CachedRemoteJwksDiscovery::new(config.jwks_url.clone(), Duration::from_secs(600)).await?)
     };
 
     database::migrate(database_connection.as_ref()).await?;