Fix IChatResponseHandlerResolver dependeny issue (#396)

MikeAlhayek · web-flow · commit dfa7e3ae7a39 · 2026-03-24T10:33:16.000-07:00
diff --git a/src/CrestApps.OrchardCore.Documentations/docs/ai/response-handlers.md b/src/CrestApps.OrchardCore.Documentations/docs/ai/response-handlers.md
@@ -1036,9 +1036,11 @@ profile.AlterSettings<ResponseHandlerProfileSettings>(settings =>
 });
 ```
 
-### Via Chat UI
+For custom clients that need to override the profile default at session start, call the chat hub directly and pass the handler name as the second argument to `AIChatHub.StartSession(profileId, initialResponseHandlerName)`.
 
-When multiple response handlers are registered, the chat UI displays a **Response Handler** dropdown in the placeholder area before a session starts. Users can select which handler to use for their session, overriding the profile's default.
+### Built-in chat UI behavior
+
+The built-in CrestApps chat UI never displays a response-handler picker to end users. Sessions always start with the AI profile's configured initial response handler, or the default AI handler when the profile does not specify one.
 
 ## SignalR Groups for Deferred Responses
 
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/Assets/js/ai-chat.js b/src/Modules/CrestApps.OrchardCore.AI.Chat/Assets/js/ai-chat.js
@@ -383,8 +383,6 @@ window.openAIChatManager = function () {
                     conversationModeEnabled: config.chatMode === 'Conversation',
                     conversationButton: null,
                     isConversationMode: false,
-                    selectedResponseHandler: '',
-                    responseHandlers: config.responseHandlers || [],
                 };
             },
             computed: {
@@ -527,50 +525,6 @@ window.openAIChatManager = function () {
                     if (bytes < 1024 * 1024) return (bytes / 1024).toFixed(1) + ' KB';
                     return (bytes / (1024 * 1024)).toFixed(1) + ' MB';
                 },
-                renderHandlerSelector() {
-                    if (!this.placeholder || this.responseHandlers.length === 0) {
-                        return;
-                    }
-
-                    var existing = this.placeholder.querySelector('.ai-chat-handler-selector');
-                    if (existing) {
-                        return;
-                    }
-
-                    var container = document.createElement('div');
-                    container.className = 'ai-chat-handler-selector mt-2';
-                    container.style.cssText = 'font-size: 0.85rem;';
-
-                    var label = document.createElement('label');
-                    label.className = 'form-label mb-1';
-                    label.style.fontSize = '0.8rem';
-                    label.textContent = 'Response Handler';
-
-                    var select = document.createElement('select');
-                    select.className = 'form-select form-select-sm';
-
-                    var defaultOption = document.createElement('option');
-                    defaultOption.value = '';
-                    defaultOption.textContent = 'Default (AI)';
-                    select.appendChild(defaultOption);
-
-                    for (var i = 0; i < this.responseHandlers.length; i++) {
-                        var handler = this.responseHandlers[i];
-                        var option = document.createElement('option');
-                        option.value = handler.name;
-                        option.textContent = handler.name;
-                        select.appendChild(option);
-                    }
-
-                    var self = this;
-                    select.addEventListener('change', function () {
-                        self.selectedResponseHandler = this.value;
-                    });
-
-                    container.appendChild(label);
-                    container.appendChild(select);
-                    this.placeholder.appendChild(container);
-                },
                 renderDocumentBar() {
                     if (!this.documentBar) return;
 
@@ -1798,21 +1752,14 @@ window.openAIChatManager = function () {
                         return;
                     }
 
-                    const handlerName = this.selectedResponseHandler || null;
-
-                    this.connection.invoke("StartSession", profileId, handlerName).catch(err => console.error(err));
+                    this.connection.invoke("StartSession", profileId, null).catch(err => console.error(err));
                 },
                 initializeApp() {
                     this.inputElement = document.querySelector(config.inputElementSelector);
                     this.buttonElement = document.querySelector(config.sendButtonElementSelector);
                     this.chatContainer = document.querySelector(config.chatContainerElementSelector);
                     this.placeholder = document.querySelector(config.placeholderElementSelector);
 
-                    // Render the handler selector in the placeholder if multiple handlers are available.
-                    if (this.placeholder && this.responseHandlers.length > 0) {
-                        this.renderHandlerSelector();
-                    }
-
                     const sessionId = this.getSessionId();
                     if (!config.widget && sessionId) {
                         this.loadSession(sessionId);
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/AIChatAdminWidget.cshtml b/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/AIChatAdminWidget.cshtml
@@ -205,18 +205,6 @@
         ["conversationButtonElementSelector"] = $"#{conversationBtnHtmlId}",
     };
 
-    var handlerResolver = ViewContext.HttpContext.RequestServices.GetService<IChatResponseHandlerResolver>();
-    if (handlerResolver != null)
-    {
-        var handlers = handlerResolver.GetAll().ToList();
-        if (handlers.Count > 1)
-        {
-            chatConfig["responseHandlers"] = handlers
-                .Select(h => new { name = h.Name })
-                .ToList();
-        }
-    }
-
     if (sessionDocumentsEnabled)
     {
         chatConfig["sessionDocumentsEnabled"] = true;
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/AIChatSessionChat.cshtml b/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/AIChatSessionChat.cshtml
@@ -187,18 +187,6 @@
         ["conversationButtonElementSelector"] = $"#{conversationBtnHtmlId}",
     };
 
-    var handlerResolver = ViewContext.HttpContext.RequestServices.GetService<IChatResponseHandlerResolver>();
-    if (handlerResolver != null)
-    {
-        var handlers = handlerResolver.GetAll().ToList();
-        if (handlers.Count > 1)
-        {
-            chatConfig["responseHandlers"] = handlers
-                .Select(h => new { name = h.Name })
-                .ToList();
-        }
-    }
-
     if (sessionDocumentsEnabled)
     {
         chatConfig["sessionDocumentsEnabled"] = true;
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/Widget-AIChat.cshtml b/src/Modules/CrestApps.OrchardCore.AI.Chat/Views/Widget-AIChat.cshtml
@@ -241,18 +241,6 @@
         ["conversationButtonElementSelector"] = $"#{conversationBtnHtmlId}",
     };
 
-    var handlerResolver = ViewContext.HttpContext.RequestServices.GetService<IChatResponseHandlerResolver>();
-    if (handlerResolver != null)
-    {
-        var handlers = handlerResolver.GetAll().ToList();
-        if (handlers.Count > 1)
-        {
-            chatConfig["responseHandlers"] = handlers
-                .Select(h => new { name = h.Name })
-                .ToList();
-        }
-    }
-
     if (sessionDocumentsEnabled)
     {
         chatConfig["sessionDocumentsEnabled"] = true;
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/wwwroot/scripts/ai-chat.js b/src/Modules/CrestApps.OrchardCore.AI.Chat/wwwroot/scripts/ai-chat.js
@@ -327,9 +327,7 @@ window.openAIChatManager = function () {
           ttsButton: null,
           conversationModeEnabled: config.chatMode === 'Conversation',
           conversationButton: null,
-          isConversationMode: false,
-          selectedResponseHandler: '',
-          responseHandlers: config.responseHandlers || []
+          isConversationMode: false
         };
       },
       computed: {
@@ -539,42 +537,6 @@ window.openAIChatManager = function () {
           if (bytes < 1024 * 1024) return (bytes / 1024).toFixed(1) + ' KB';
           return (bytes / (1024 * 1024)).toFixed(1) + ' MB';
         },
-        renderHandlerSelector: function renderHandlerSelector() {
-          if (!this.placeholder || this.responseHandlers.length === 0) {
-            return;
-          }
-          var existing = this.placeholder.querySelector('.ai-chat-handler-selector');
-          if (existing) {
-            return;
-          }
-          var container = document.createElement('div');
-          container.className = 'ai-chat-handler-selector mt-2';
-          container.style.cssText = 'font-size: 0.85rem;';
-          var label = document.createElement('label');
-          label.className = 'form-label mb-1';
-          label.style.fontSize = '0.8rem';
-          label.textContent = 'Response Handler';
-          var select = document.createElement('select');
-          select.className = 'form-select form-select-sm';
-          var defaultOption = document.createElement('option');
-          defaultOption.value = '';
-          defaultOption.textContent = 'Default (AI)';
-          select.appendChild(defaultOption);
-          for (var i = 0; i < this.responseHandlers.length; i++) {
-            var handler = this.responseHandlers[i];
-            var option = document.createElement('option');
-            option.value = handler.name;
-            option.textContent = handler.name;
-            select.appendChild(option);
-          }
-          var self = this;
-          select.addEventListener('change', function () {
-            self.selectedResponseHandler = this.value;
-          });
-          container.appendChild(label);
-          container.appendChild(select);
-          this.placeholder.appendChild(container);
-        },
         renderDocumentBar: function renderDocumentBar() {
           if (!this.documentBar) return;
           if (!config.sessionDocumentsEnabled) {
@@ -1849,8 +1811,7 @@ window.openAIChatManager = function () {
           if (!profileId || !this.connection) {
             return;
           }
-          var handlerName = this.selectedResponseHandler || null;
-          this.connection.invoke("StartSession", profileId, handlerName)["catch"](function (err) {
+          this.connection.invoke("StartSession", profileId, null)["catch"](function (err) {
             return console.error(err);
           });
         },
@@ -1860,11 +1821,6 @@ window.openAIChatManager = function () {
           this.buttonElement = document.querySelector(config.sendButtonElementSelector);
           this.chatContainer = document.querySelector(config.chatContainerElementSelector);
           this.placeholder = document.querySelector(config.placeholderElementSelector);
-
-          // Render the handler selector in the placeholder if multiple handlers are available.
-          if (this.placeholder && this.responseHandlers.length > 0) {
-            this.renderHandlerSelector();
-          }
           var sessionId = this.getSessionId();
           if (!config.widget && sessionId) {
             this.loadSession(sessionId);
diff --git a/src/Modules/CrestApps.OrchardCore.AI.Chat/wwwroot/scripts/ai-chat.min.js b/src/Modules/CrestApps.OrchardCore.AI.Chat/wwwroot/scripts/ai-chat.min.js
diff --git a/src/Modules/CrestApps.OrchardCore.AI/Drivers/AIProfileResponseHandlerDisplayDriver.cs b/src/Modules/CrestApps.OrchardCore.AI/Drivers/AIProfileResponseHandlerDisplayDriver.cs
@@ -27,10 +27,10 @@ public AIProfileResponseHandlerDisplayDriver(
 
     public override IDisplayResult Edit(AIProfile profile, BuildEditorContext context)
     {
-        var handlers = _handlerResolver.GetAll().ToList();
+        var handlers = _handlerResolver.GetAll();
 
         // Only show the handler selector when there is at least one non-AI handler registered.
-        if (handlers.Count <= 1)
+        if (!handlers.Any())
         {
             return null;
         }
diff --git a/src/Modules/CrestApps.OrchardCore.AI/Startup.cs b/src/Modules/CrestApps.OrchardCore.AI/Startup.cs
@@ -72,7 +72,6 @@ public override void ConfigureServices(IServiceCollection services)
             .AddScoped<CitationReferenceCollector>()
             .AddScoped<IAICompletionContextBuilderHandler, AIProfileCompletionContextBuilderHandler>()
             .AddDisplayDriver<AIProfile, AIProfileDisplayDriver>()
-            .AddDisplayDriver<AIProfile, AIProfileResponseHandlerDisplayDriver>()
             .AddTransient<IConfigureOptions<DefaultAIOptions>, DefaultAIOptionsConfiguration>()
             .AddScoped(sp =>
             {
@@ -243,6 +242,8 @@ public override void ConfigureServices(IServiceCollection services)
             .AddIndexProvider<AIChatSessionIndexProvider>()
             .AddSingleton<IBackgroundTask, AIChatSessionCloseBackgroundTask>();
 
+        services.AddDisplayDriver<AIProfile, AIProfileResponseHandlerDisplayDriver>();
+
         // Register the AI chat session prompt store.
         services.AddScoped<DefaultAIChatSessionPromptStore>()
             .AddScoped<IAIChatSessionPromptStore>(sp => sp.GetRequiredService<DefaultAIChatSessionPromptStore>())

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,10 @@ public AIProfileResponseHandlerDisplayDriver(`
`27`	`27`
`28`	`28`	`public override IDisplayResult Edit(AIProfile profile, BuildEditorContext context)`
`29`	`29`	`{`
`30`		`- var handlers = _handlerResolver.GetAll().ToList();`
	`30`	`+ var handlers = _handlerResolver.GetAll();`
`31`	`31`
`32`	`32`	`// Only show the handler selector when there is at least one non-AI handler registered.`
`33`		`- if (handlers.Count <= 1)`
	`33`	`+ if (!handlers.Any())`
`34`	`34`	`{`
`35`	`35`	`return null;`
`36`	`36`	`}`