Fix a bug with the multipleSelect selector

Author: MikeAlhayek

CHANGELOG.md

@@ -1,4 +1,5 @@
 ### Upgrade
+ - If you are upgrading from v2.0, v2.1, v2.2, v2.3 to v2.4 make sure you publish the vendor resource. There are some updates to the config file.
  - If you are upgrading from v2.0, v2.1 or v2.2 to v2.3 make sure you publish the vendor resource. There are some updates to the config file.
  - If you are upgrading from v2.0 or v2.1 to v2.2 make sure you publish the vendor resource. There are some changes to the templates that required to be updated.
 -- If you are upgrading any version prior v2.2 follow the upgrate instruction on https://crestapps.com/laravel-code-generator/docs/2.2#upgrade-guide

composer.json

@@ -2,7 +2,7 @@
     "name": "crestapps/laravel-code-generator",
     "license": "MIT",
     "description": "A clean code generator for Laravel framework that will save you time! This awesome tool will help you generate resources like views, controllers, routes, migrations, languages or request-forms! It is extremely flexible and customizable to cover many use cases. It is shipped with cross-browsers compatible template, along with a client-side validation to modernize your application.",
-    "version": "v2.2.3",
+    "version": "v2.2.4",
     "keywords": [
         "laravel","crud","crud generator",
         "laravel crud generator","laravel crud builder",

config/codegenerator.php

@@ -252,6 +252,7 @@
         'password' => 'Enter [% field_name %] here...',
         'email' => 'Enter [% field_name %] here...',
         'select' => 'Select [% field_name %]',
+        'multipleSelect' => 'Select [% field_name %]',
     ],
 
     /*

src/HtmlGenerators/LaravelCollectiveHtml.php

@@ -229,7 +229,7 @@ protected function getMultipleRawOptionValue($name, $value, $defaultValue)
         $modelVariable = $this->getSingularVariable($this->modelName);
         $valueString = 'null';
         if (!is_null($value)) {
-            $valueString = starts_with('$', $value) ? sprintf("%s", $value) : sprintf("'%s'", $value);
+            $valueString = starts_with($value, '$') ? sprintf("%s", $value) : sprintf("'%s'", $value);
         }
         $defaultValueString = '[]';
         if (!empty($defaultValue)) {
@@ -273,7 +273,7 @@ protected function getDefaultValueAccessor($modelVariable, $property, $value)
      */
     protected function getMultipleSelectedValue($name, $valueAccessor, $defaultValue)
     {
-        return sprintf(" (%s ? true : null) ", $name);
+        return sprintf(" (%s ? true : null) ", $this->getMultipleRawOptionValue($name, $valueAccessor, $defaultValue));
     }
 
     /**

src/HtmlGenerators/StandardHtml.php

@@ -112,7 +112,7 @@ protected function getFieldPlaceHolderForMenu(Label $placeholder = null, $name =
      */
     protected function getFieldMultiple($isMulti)
     {
-        return $isMulti ? 'multiple="multiple"' : '';
+        return $isMulti ? ' multiple="multiple"' : '';
     }
 
     /**
@@ -188,6 +188,7 @@ protected function getCheckedItem($value, $name, $defaultValue)
      */
     protected function getMultipleCheckedItem($value, $name, $defaultValue)
     {
+
         return sprintf(" {{ %s ? 'checked' : '' }}", $this->getMultipleRawOptionValue($name, $value, $defaultValue));
     }
 
@@ -226,7 +227,7 @@ protected function getDefaultValueAccessor($modelVariable, $property, $value)
      */
     protected function getMultipleSelectedValue($name, $valueAccessor, $defaultValue)
     {
-        return sprintf(" {{ %s ? 'selected' : '' }}", $name);
+        return sprintf(" {{ %s ? 'selected' : '' }}", $this->getMultipleRawOptionValue($name, $valueAccessor, $defaultValue));
     }
 
     /**
@@ -277,7 +278,7 @@ protected function getMultipleRawOptionValue($name, $value, $defaultValue)
         $valueString = 'null';
 
         if (!is_null($value)) {
-            $valueString = starts_with('$', $value) ? sprintf("%s", $value) : sprintf("'%s'", $value);
+            $valueString = starts_with($value, '$') ? sprintf("%s", $value) : sprintf("'%s'", $value);
         }
 
         $defaultValueString = '[]';