Mailbox/App: Fix paralleling file download. Fix #1170

Author: JulianAdams4

electron_app/package.json

@@ -18,6 +18,7 @@
   "scripts": {
     "electron": "electron .",
     "start": "npm run electron .",
+    "start:dev": "npm run electron . --allow-file-access-from-file",
     "postinstall": "install-app-deps",
     "test": "criptext-js-tools test",
     "integration": "NODE_ENV=test criptext-js-tools integration",

electron_app/src/ipc/mailbox.js

@@ -1,5 +1,5 @@
 const ipc = require('@criptext/electron-better-ipc');
-const { app, BrowserWindow } = require('electron');
+const { app } = require('electron');
 const unusedFilename = require('unused-filename');
 const { download } = require('electron-dl');
 const path = require('path');
@@ -67,21 +67,13 @@ ipc.answerRenderer(
         metadataKey
       });
       const filePath = path.join(directory, filename);
-      if (isInlineImage) {
-        if (checkIfExists(filePath)) return filePath;
-      } else {
+      if (!isInlineImage) {
         filename = path.basename(unusedFilename.sync(filePath));
       }
-
-      const downloadedItem = await download(
-        BrowserWindow.getFocusedWindow(),
-        url,
-        {
-          directory,
-          filename,
-          openFolderWhenDone: !isInlineImage
-        }
-      );
+      const downloadedItem = await download(mailboxWindow.getWindow(), url, {
+        directory,
+        filename
+      });
       const newFilePath = downloadedItem.getSavePath();
       return { filePath: newFilePath, filename };
     } catch (e) {

electron_app/src/windows/mailbox.js

@@ -180,10 +180,14 @@ const isVisibleAndFocused = () => {
   return mailboxWindow.isVisible() && mailboxWindow.isFocused();
 };
 
+function getWindow() {
+  return mailboxWindow;
+}
+
 module.exports = {
   close,
   hide,
-  mailboxWindow,
+  getWindow,
   send,
   show,
   isVisibleAndFocused,

email_mailbox/src/containers/Email.js

@@ -1,3 +1,4 @@
+/* eslint-env node, process */
 import { connect } from 'react-redux';
 import { makeGetFiles } from './../selectors/files';
 import EmailView from './../components/EmailWrapper';
@@ -116,6 +117,12 @@ const makeMapStateToProps = () => {
   return mapStateToProps;
 };
 
+const defineInjectedSrc = imgPath => {
+  return `src="${
+    process.env.NODE_ENV === 'development' ? 'file://' : ''
+  }${imgPath}"`;
+};
+
 const mapDispatchToProps = (dispatch, ownProps) => {
   const email = ownProps.email;
   const isLast = ownProps.staticOpen;
@@ -283,7 +290,7 @@ const mapDispatchToProps = (dispatch, ownProps) => {
           const imgPath = cidFilepathPairs[cid];
           return emailContentInjected.replace(
             `src="cid:${cid}"`,
-            `src="${imgPath}"`
+            defineInjectedSrc(imgPath)
           );
         },
         emailContent