Fix recording the initial condition

The previous implementation incorrectly uses the simulation horizon for calculations. The correct parameter is using 24-hours since we do a rolling simulation to simulate day-ahead dispatch.

Author: phumthep

scripts/run_pownet.py

@@ -12,7 +12,7 @@
 ##### User inputs #####
 to_process_inputs = True
 sim_horizon = 24
-model_name = "RegionAB"
+model_name = "dummy"
 steps_to_run = 3  # Default is None
 do_plot = True
 #######################

src/pownet/core/record.py

@@ -77,8 +77,7 @@ def _extract_vartype_data(df: pd.DataFrame, vartype: str) -> dict[str, float]:
             """Extracts data for a specific 'vartype' from the DataFrame and converts it to a dictionary."""
             return (
                 df[
-                    (df["vartype"] == vartype)
-                    & (df["timestep"] == self.inputs.sim_horizon)
+                    (df["vartype"] == vartype) & (df["timestep"] == 24)
                 ]  # Only considers values of the last hour
                 .drop("vartype", axis=1)
                 .set_index(["node"])  # Assume generator names do not repeat
@@ -110,13 +109,13 @@ def _extract_vartype_data(df: pd.DataFrame, vartype: str) -> dict[str, float]:
         # Need to calculate the minimum time on/off
         self.current_min_on = calc_remaining_on_duration(
             current_node_vars,
-            sim_horizon=self.inputs.sim_horizon,
+            sim_horizon=24,
             thermal_units=self.inputs.thermal_units,
             TU=self.inputs.TU,
         )
         self.current_min_off = calc_remaining_off_duration(
             current_node_vars,
-            sim_horizon=self.inputs.sim_horizon,
+            sim_horizon=24,
             thermal_units=self.inputs.thermal_units,
             TD=self.inputs.TD,
         )