Check text direction has 1 of 2 valid values

Crizz0 · Crizz0 · commit 9d218184b219 · 2025-09-26T14:26:13.000+02:00
diff --git a/src/Phpbb/TranslationValidator/Validator/FileValidator.php b/src/Phpbb/TranslationValidator/Validator/FileValidator.php
@@ -655,8 +655,8 @@ public function validateJsonFile($originFile)
             $this->output->addMessage(Output::FATAL, 'The phpbb-version value should not be empty and contain a valid version number.', $originFile);
         }
         // Check for valid direction
-        $direction = $jsonContent['extra']['direction'];
-        if (!in_array($direction, array('ltr', 'rtl')))
+        $textDirection = $jsonContent['extra']['direction'];
+        if (!in_array($textDirection, array('ltr', 'rtl')))
         {
             $this->output->addMessage(Output::FATAL, 'The direction can only be rtl or ltr.', $originFile);
         }

Original file line number	Diff line number	Diff line change
`@@ -655,8 +655,8 @@ public function validateJsonFile($originFile)`
`655`	`655`	`$this->output->addMessage(Output::FATAL, 'The phpbb-version value should not be empty and contain a valid version number.', $originFile);`
`656`	`656`	`}`
`657`	`657`	`// Check for valid direction`
`658`		`- $direction = $jsonContent['extra']['direction'];`
`659`		`- if (!in_array($direction, array('ltr', 'rtl')))`
	`658`	`+ $textDirection = $jsonContent['extra']['direction'];`
	`659`	`+ if (!in_array($textDirection, array('ltr', 'rtl')))`
`660`	`660`	`{`
`661`	`661`	`$this->output->addMessage(Output::FATAL, 'The direction can only be rtl or ltr.', $originFile);`
`662`	`662`	`}`