Skip to content

Commit d80e374

Browse files
authored
fix: add missing environment to release workflow jobs (#258)
* fix: add missing environment to release workflow jobs The container and deployer jobs were missing `environment: release`, preventing them from accessing GitHub environment-scoped secrets required by google-github-actions/auth and other steps. * fix: suppress pylint too-many-instance-attributes for StreamingThread
1 parent 8a18834 commit d80e374

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ jobs:
4040
container:
4141
runs-on: ubuntu-latest
4242
timeout-minutes: 30
43+
environment: release
4344
permissions:
4445
contents: "read"
4546
id-token: "write"
@@ -91,6 +92,7 @@ jobs:
9192
deployer:
9293
runs-on: ubuntu-latest
9394
timeout-minutes: 30
95+
environment: release
9496
permissions:
9597
contents: "read"
9698
id-token: "write"

fig/falcon/stream.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def refresh_stream_session(self):
8080
log.debug("Refresh of streaming session succeeded")
8181

8282

83-
class StreamingThread(StoppableThread):
83+
class StreamingThread(StoppableThread): # pylint: disable=too-many-instance-attributes
8484
def __init__(self, stream: Stream, queue, relevant_event_types, *args, **kwargs):
8585
kwargs['name'] = kwargs.get('name', 'cs_stream')
8686
super().__init__(*args, **kwargs)

0 commit comments

Comments
 (0)