Skip to content

Commit 5c54ce1

Browse files
committed
Add sane boundaries to the random_string generator
1 parent 8578f94 commit 5c54ce1

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/falconpy/_constant/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,5 @@
7474
MAX_TOKEN_RENEW_WINDOW: int = 1200
7575
# Minimum available token renew window (in seconds).
7676
MIN_TOKEN_RENEW_WINDOW: int = 120
77+
# Maximum length for strings generated with the random_string function (in seconds).
78+
MAX_RANDOM_STRING_LENGTH: int = 4096

src/falconpy/_helper/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"""
3838
from secrets import choice
3939
from string import ascii_letters, digits
40+
from .._constant import MAX_RANDOM_STRING_LENGTH
4041
from ._text_colors import Color
4142
from ._indicator import Indicator
4243
from ._find_operation import find_operation
@@ -53,8 +54,9 @@ def random_string(length: int = 10,
5354
character_set = character_set + (ascii_letters if include_letters else "")
5455
character_set = character_set + (digits if include_digits else "")
5556
character_set = character_set + ("!@#$%?&*_." if include_specials else "")
57+
gen_length = max(1, min(length, MAX_RANDOM_STRING_LENGTH))
5658
if character_set:
57-
returned = "".join(choice(character_set) for _ in range(length))
59+
returned = "".join(choice(character_set) for _ in range(gen_length))
5860

5961
return returned
6062

0 commit comments

Comments
 (0)