Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

Commit 2b96672

Browse files
ynotdrawclintcs
andauthored
Update README and CONTRIBUTING (#684)
* Update README and CONTRIBUTING * Update CONTRIBUTING.md Co-authored-by: clintcs <[email protected]> * Update CONTRIBUTING.md Co-authored-by: clintcs <[email protected]> --------- Co-authored-by: clintcs <[email protected]>
1 parent f9ef94a commit 2b96672

File tree

2 files changed

+60
-62
lines changed

2 files changed

+60
-62
lines changed

CONTRIBUTING.md

Lines changed: 54 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
# Contributing Guidelines
2-
3-
- [Development setup](#development-setup)
4-
- [Forking the repository](#forking-the-repository)
5-
- [Don't reference internal systems, issues, or links](#dont-reference-internal-systems-issues-or-links)
6-
- [Versioning a package](#versioning-a-package)
1+
# Contributing
2+
3+
- [Development](#development)
4+
- [Forking the repository](#forking-the-repository)
5+
- [Don't reference internal systems, issues, or links](#dont-reference-internal-systems-issues-or-links)
6+
- [Getting started](#getting-started)
7+
- [Adding a release note](#adding-a-release-note)
8+
- [Updating style variables](#updating-style-variables)
9+
- [Translations and static strings](#translations-and-static-strings)
710
- [Best practices](#best-practices)
811
- [Proceed with caution when upgrading Storybook](#proceed-with-caution-when-upgrading-storybook)
912
- [Prefer controls over stories](#prefer-controls-over-stories)
@@ -26,38 +29,68 @@
2629
- [Bubble and compose events](#bubble-and-compose-events)
2730
- [Avoid custom events](#avoid-custom-events)
2831
- [Override and decorate inherited properties used in templates](#override-and-decorate-inherited-properties-used-in-templates)
29-
- [Translations and static strings](#translations-and-static-strings)
3032
- [Questions](#questions)
3133
- [What is `per-env`?](#what-is-per-env)
3234

3335
## Development
3436

35-
Follow the instructions in [README](./README.md) to set up your machine for development.
36-
37-
## Forking the repository
37+
### Forking the repository
3838

3939
If you are a member of the CrowdStrike GitHub organization, you can branch off of `main`.
4040
For those not in the organization, you can [fork the repository](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo) and contribute as if you were contributing to any other open source project on GitHub.
4141

42-
## Don't reference internal systems, issues, or links
42+
### Don't reference internal systems, issues, or URLs
43+
44+
> [!WARNING]
45+
> When writing commit messages, creating branch names, providing Pull Request feedback, and creating Pull Request descriptions, one must take caution in what is written.
46+
> This content **cannot** contain references to internal systems, proprietary images or source code, or anything else that could harm CrowdStrike or any other organization or individual contributing to this repository.
47+
> Use common sense. If you're unsure, please ask the team for guidance.
48+
49+
### Getting started
50+
51+
We recommend using [Corepack](https://pnpm.io/installation#using-corepack) to manage PNPM.
52+
53+
```bash
54+
pnpm install
55+
pnpm start
56+
```
57+
58+
- If you have `ignore-scripts=true` in your `~/.npmrc`, also run `pnpm prepare` to install the Git hooks.
4359

44-
When writing commit messages, providing Pull Request feedback, and creating Pull Request descriptions, one must take caution in what is written.
45-
This content **cannot** contain references to internal systems, proprietary images or source code, or anything else that could harm CrowdStrike or any other organization or individual contributing to this repository.
46-
Use common sense. If you're unsure, please ask the team for guidance.
60+
Read through the remainder of this document before opening a pull request.
4761

48-
## Versioning a package
62+
### Adding a release note
4963

50-
We use [changesets](https://github.com/changesets/changesets) to manage our release notes.
51-
Include a changeset with your Pull Request if the change you made is one that consumers should know about:
64+
We use [Changesets](https://github.com/changesets/changesets) for release notes.
65+
Include one with your Pull Request if you made a change consumers should know about:
5266

5367
```bash
5468
pnpm changeset
5569
```
5670

57-
You'll be prompted to select the type of change according to [Semantic Versioning](https://semver.org).
58-
You'll also be prompted for a description.
59-
Descriptions are used in our release notes for consumers.
60-
So be sure to be as descriptive and helpful as possible.
71+
1. Select the type of change according to [Semantic Versioning](https://semver.org).
72+
1. Add a concise but comprehensive description.
73+
74+
### Updating style variables
75+
76+
1. Generate a Figma [personal access token](https://help.figma.com/hc/en-us/articles/8085703771159-Manage-personal-access-tokens).
77+
1. `FIGMA_TOKEN=<token> pnpm start:production:figma`
78+
79+
### Translations and static strings
80+
81+
Most of the text we render is provided by the consumer directly; however, we do have a few cases where we have static strings in place.
82+
In particular, static strings are helpful for screenreaders so that our components can provide additional context for accessibility.
83+
84+
The process for adding static strings is as follows:
85+
86+
1. Update the type definition at [`src/library/localize.ts`](https://github.com/CrowdStrike/glide-core/blob/main/src/library/localize.ts) to include your new string.
87+
1. Add the new string directly to [`src/translations/en.ts`](https://github.com/CrowdStrike/glide-core/blob/main/src/translations/en.ts). This is what will be used in code.
88+
1. Add the new string in the JSON format to [`src/translations/en.json`](https://github.com/CrowdStrike/glide-core/blob/main/src/translations/en.json).
89+
1. Copy the additions from `src/translations/en.ts` and `src/translations/en.json` to the other language files.
90+
91+
The non-English languages will fallback to English until they are translated.
92+
The `src/translations/en.json` will be sent to our translation team and returned for each language we support.
93+
When a new file is received from the translators, please update all `src/translations/*.json` and `src/translations/*.ts` files with the updated strings.
6194

6295
## Best practices
6396

@@ -558,22 +591,6 @@ Many components don't change inherited properties internally.
558591
However, if one is made to after the fact, it may result in a subtle bug.
559592
So it's best to always override and decorate (using `@property`) inherited properties used in templates.
560593
561-
### Translations and static strings
562-
563-
Most of the text we render is provided by the consumer directly; however, we do have a few cases where we have static strings in place.
564-
In particular, static strings are helpful for screenreaders so that our components can provide additional context for accessibility.
565-
566-
The process for adding static strings is as follows:
567-
568-
1. Update the type definition at [`src/library/localize.ts`](https://github.com/CrowdStrike/glide-core/blob/main/src/library/localize.ts) to include your new string.
569-
2. Add the new string directly to [`src/translations/en.ts`](https://github.com/CrowdStrike/glide-core/blob/main/src/translations/en.ts). This is what will be used in code.
570-
3. Add the new string in the JSON format to [`src/translations/en.json`](https://github.com/CrowdStrike/glide-core/blob/main/src/translations/en.json).
571-
4. Copy the additions from `src/translations/en.ts` and `src/translations/en.json` to the other language files.
572-
573-
The non-English languages will fallback to English until they are translated.
574-
The `src/translations/en.json` will be sent to our translation team and returned for each language we support.
575-
When a new file is received from the translators, please update all `src/translations/*.json` and `src/translations/*.ts` files with the updated strings.
576-
577594
## Questions
578595
579596
### What is [`per-env`](https://github.com/ericclemmons/per-env)?

README.md

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
1-
<div align="center">
1+
<p align="center">
22
<a href="https://glide-core.crowdstrike-ux.workers.dev">
33
<picture alt="Glide Core Logo">
44
<source srcset="https://github.com/CrowdStrike/glide-core/blob/main/.github/logos/light.png?raw=true" media="(prefers-color-scheme: light)" />
55
<source srcset="https://github.com/CrowdStrike/glide-core/blob/main/.github/logos/dark.png?raw=true" media="(prefers-color-scheme: dark)" />
66
<img src="https://github.com/CrowdStrike/glide-core/blob/main/.github/logos/light.png?raw=true" width="500" />
77
</picture>
8-
98
</a>
9+
</p>
1010

11-
<p align="center">
12-
A Web Component design system from CrowdStrike.
13-
</p>
14-
</div>
11+
<p align="center">
12+
A Web Component design system from CrowdStrike.
13+
</p>
1514

1615
## Usage
1716

1817
### 1. Install the dependencies
1918

2019
```bash
21-
$ pnpm install @crowdstrike/glide-core lit
20+
pnpm install @crowdstrike/glide-core lit
2221
```
2322

2423
### 2. Import the fonts and variables
@@ -39,21 +38,3 @@ import '@crowdstrike/glide-core/button.js';
3938
```html
4039
<glide-core-button label="Button"></glide-core-button>
4140
```
42-
43-
## Development
44-
45-
### Getting started
46-
47-
```bash
48-
$ pnpm install
49-
$ pnpm start
50-
```
51-
52-
- Follow our [contribution guidelines](./CONTRIBUTING.md) before opening a pull request.
53-
- We recommend using [Corepack](https://pnpm.io/installation#using-corepack) to manage PNPM.
54-
- If you have `ignore-scripts=true` in your `~/.npmrc`, also run `pnpm prepare` to install the Git hooks.
55-
56-
### Updating style variables
57-
58-
1. Generate a Figma [personal access token](https://help.figma.com/hc/en-us/articles/8085703771159-Manage-personal-access-tokens).
59-
1. `$ FIGMA_TOKEN=<token> pnpm start:production:figma`

0 commit comments

Comments
 (0)