Fix precommit linting issues (#413)

* fix: use the proper views for pgmonitor-extension queries. doc update. new table stat metric

* chore: add changelog fragment

* chore: correct precommit linting

Author: keithf4

.pre-commit-config.yaml

@@ -3,7 +3,7 @@ default_install_hook_types:
   - pre-commit
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v4.3.0
+  rev: v4.6.0
   hooks:
     - id: check-merge-conflict
     - id: check-symlinks
@@ -15,25 +15,11 @@ repos:
     - id: trailing-whitespace
       args: ['--markdown-linebreak-ext=md']
 - repo: https://github.com/alessandrojcm/commitlint-pre-commit-hook
-  rev: v9.0.0
+  rev: v9.16.0
   hooks:
     - id: commitlint
       stages: [commit-msg]
       additional_dependencies: ['@commitlint/config-conventional']
-- repo: https://github.com/ansible-community/ansible-lint.git
-  rev: v5.4.0
-    # rev: v5.4.0 will not change until we drop ansible 2.9
-  hooks:
-    - id: ansible-lint
-      always_run: true
-      pass_filenames: false
-      # do not add file filters here as ansible-lint does not give reliable
-      # results when called with individual files.
-      # https://github.com/ansible/ansible-lint/issues/611
-      verbose: true
-      entry: ansible-lint --force-color -p -v .
-      additional_dependencies:
-        - 'ansible<2.10'
 - repo: https://github.com/codespell-project/codespell
   rev: v2.1.0
   hooks:

blackbox_exporter/common/blackbox_exporter.sysconfig

@@ -7,4 +7,3 @@
 # This file must be in a pathname that matches the EnvironmentFile entry in the service file (Default: /etc/sysconfig/blackbox_exporter)
 #
 OPT="--config.file=/etc/blackbox_exporter/crunchy-blackbox.yml"
-

build/packages.yml

@@ -108,7 +108,7 @@ packages:
 
     - sql-exporter:
         files:
-          - { source: "https://github.com/CrunchyData/pgmonitor/sql_exporter/linux/crunchy-sql-exporter@.service" target: "/usr/lib/systemd/system/crunchy-sql-exporter@.service", mode: "0645", type: "file", owner: "root", group: "root" }
+          - { source: "https://github.com/CrunchyData/pgmonitor/sql_exporter/linux/crunchy-sql-exporter@.service", target: "/usr/lib/systemd/system/crunchy-sql-exporter@.service", mode: "0645", type: "file", owner: "root", group: "root" }
           - { target: "/usr/bin/sql_exporter", mode: "0755", type: "file", owner: "root", group: "root" }
           - { target: "/etc/sql_exporter", type: "folder", mode: "0755", owner: "root", group: "root" }
         upstream_repo: "https://github.com/burningalchemist/sql_exporter"
@@ -160,9 +160,9 @@ packages:
         files:
           - { source: "grafana/linux/Filesystem_Details.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
           - { source: "grafana/linux/Network_Details.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
-           - { source: "grafana/linux/OS_Details.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
-           - { source: "grafana/linux/OS_Overview.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
-         pkg_dependency:
+          - { source: "grafana/linux/OS_Details.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
+          - { source: "grafana/linux/OS_Overview.json", target: "/etc/grafana/crunchy_dashboards/", mode: "0640", type: "file", rpm_new: false, owner: "grafana", group: "grafana" }
+        pkg_dependency:
           - { pkg_name: "pgmonitor-grafana-extras-common" }
         upstream_repo: "https://github.com/CrunchyData/pgmonitor"
 

changelogs/fragments/361.yml

@@ -6,5 +6,5 @@ major_changes:
   - postgres_exporter - Note that postgres_exporter is still supported but will be deprecated in a future version
   - grafana - New Grafana minimum version is now 10.4. All dashboards have been updated to fix AngularJS deprecation warnings and re-exported from 10.4.
   - grafana - Add new dashboards for sql_exporter support. New PostgreSQL Overview and PgBouncer direct metrics dashboards
-  - grafana - Organize packages to allow better choice of available Grafana dashboards 
+  - grafana - Organize packages to allow better choice of available Grafana dashboards
   - grafana - Remove top level general Overview dashboard

changelogs/fragments/399.yml

@@ -3,4 +3,3 @@ trivial:
   - packaging - Update the build file to set blackbox-exporter-extras group to ccp_monitoring for consistency with other extras packages
   - packaging - Take out remove_files lines since the files referenced have been gone for a long time now and packages aren't doing that anymore
   - packaging - Take out package conflicts with containers packages. There are no containers packages being done at this time
-

changelogs/fragments/412.yml

@@ -1,3 +1,4 @@
 bugfixes:
   - sql_exporter - use the new views from pgmonitor-extension instead of full queries
+  - sql_exporter - add new metric for n_tup_newpage_upd
   - docs - add reference links to upstream configuration docs

grafana/common/crunchy_grafana_datasource.yml

@@ -17,4 +17,3 @@ datasources:
     editable: False
     orgId: 1
     version: 1
-

hugo/archetypes/default.md

@@ -3,4 +3,3 @@ title: "{{ replace .Name "-" " " | title }}"
 date: {{ .Date }}
 draft: true
 ---
-

hugo/content/_index.md

@@ -93,4 +93,3 @@ Copyright © 2017-2024 Crunchy Data Solutions, Inc. All Rights Reserved.
 CRUNCHY DATA SOLUTIONS, INC. PROVIDES THIS GUIDE "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF NON INFRINGEMENT, MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE.
 
 Crunchy, Crunchy Data Solutions, Inc. and the Crunchy Hippo Logo are trademarks of Crunchy Data Solutions, Inc. All Rights Reserved.
-

hugo/content/changelog/v5_upgrade/_index.md

@@ -23,7 +23,7 @@ sudo systemctl disable crunchy-postgres-exporter@postgres_exporter_pg##_per_db
 
 Note the values after the @ symbol may be different depending on the sysconfig files that have been created for your exporters. There may also be exporters running for multiple clusters and we would recommend replacing all of the existing postgres_exporters with the new sql_exporter.
 
-If you've installed pgMonitor with the packages provided by Crunchy Data, those packages can now be uninstalled as well. 
+If you've installed pgMonitor with the packages provided by Crunchy Data, those packages can now be uninstalled as well.
 
 | Package Name                   | Description                                                               |
 |--------------------------------|---------------------------------------------------------------------------|
@@ -50,7 +50,7 @@ If postgres_exporter was not set up with packages, you can now manually remove a
 
 
 ### Prometheus
-All postgres_exporter Prometheus targets can now be removed. The default location for Prometheus targets is `/etc/prometheus/auto.d/`, but please check your Prometheus installation for possible additional target locations. In the identified location(s), remove any targets for the postgres_exporter. The default ports for postgres_exporter were 9187 and 9188, so any targets with these ports should be examined for removal. Note that if alerting had previously been enabled, the previous step likely caused multiple alerts to fire; once this step is done, you can simply reload Prometheus to clear these targets and any related alerts should resolve themselves. 
+All postgres_exporter Prometheus targets can now be removed. The default location for Prometheus targets is `/etc/prometheus/auto.d/`, but please check your Prometheus installation for possible additional target locations. In the identified location(s), remove any targets for the postgres_exporter. The default ports for postgres_exporter were 9187 and 9188, so any targets with these ports should be examined for removal. Note that if alerting had previously been enabled, the previous step likely caused multiple alerts to fire; once this step is done, you can simply reload Prometheus to clear these targets and any related alerts should resolve themselves.
 
 ```bash
 sudo systemctl reload prometheus