Updated KUTTL E2Es for POSIX standard shells

Overall reference
- https://www.gnu.org/software/bash/manual/html_node/Major-Differences-From-The-Bourne-Shell.html

Some specific items include:

Double equals ('==') not supported by all POSIX shells.
- https://www.shellcheck.net/wiki/SC3014

printf %q not supported by all POSIX shells.
- https://ss64.com/bash/printf.html
- https://www.shellcheck.net/wiki/SC3050

arithmetic for loops are undefined
- https://www.shellcheck.net/wiki/SC3005

regex matching (=~) is undefined
- https://www.shellcheck.net/wiki/SC3015

cannot match globs in [..]
- https://www.shellcheck.net/wiki/SC2081

cannot use logical operators in [..]
- https://www.shellcheck.net/wiki/SC2107

Issue: PGO-716

Author: tjmoore4

testing/kuttl/e2e/backup/01--check-pod-command.yaml

@@ -6,7 +6,7 @@ commands:
 - script: |
     # Retry getting a successful pod from the most recent backup job.
     # If that pod doesn't have the expected command, sleep and retry
-    for i in {1..10}; do
+    i=1; while [ $i -le 10 ]; do
       BACKUP_COMMAND=$(
           kubectl get pod --namespace "${NAMESPACE}" \
             --output jsonpath="{.items[*].spec.containers[*].env[?(@.name=='COMMAND_OPTS')].value}" \
@@ -19,10 +19,11 @@ commands:
 
       echo "BACKUP_COMMAND found ${BACKUP_COMMAND}"
 
-      if [[ -n $BACKUP_COMMAND && "$BACKUP_COMMAND" == "--stanza=db --repo=1" ]]; then
+      if [ -n "$BACKUP_COMMAND" ] && [ "$BACKUP_COMMAND" = "--stanza=db --repo=1" ]; then
           exit 0
       fi
       sleep 4
+      i=$(( i + 1 ))
     done
     
     exit 1

testing/kuttl/e2e/backup/02--backup-with-flags.yaml

@@ -6,7 +6,7 @@ commands:
 
     echo "RESULT from taking backup: ${RESULT}"
 
-    if [[ -n $RESULT && "$RESULT" == "postgresclusters/backup-cluster backup initiated" ]]; then
+    if [ -n "$RESULT" ] && [ "$RESULT" = "postgresclusters/backup-cluster backup initiated" ]; then
         exit 0
     fi
 

testing/kuttl/e2e/backup/03--check-pod-command-with-flags.yaml

@@ -6,7 +6,7 @@ commands:
 - script: |
     # Retry getting a successful pod from the most recent backup job.
     # If that pod doesn't have the expected command, sleep and retry
-    for i in {1..10}; do
+    i=1; while [ $i -le 10 ]; do
       BACKUP_COMMAND=$(
           kubectl get pod --namespace "${NAMESPACE}" \
             --output jsonpath="{.items[*].spec.containers[*].env[?(@.name=='COMMAND_OPTS')].value}" \
@@ -19,10 +19,11 @@ commands:
 
       echo "BACKUP_COMMAND found ${BACKUP_COMMAND}"
 
-      if [[ -n $BACKUP_COMMAND && "$BACKUP_COMMAND" == "--stanza=db --repo=1 --type=full" ]]; then
+      if [ -n "$BACKUP_COMMAND" ] && [ "$BACKUP_COMMAND" = "--stanza=db --repo=1 --type=full" ]; then
           exit 0
       fi
       sleep 4
+      i=$(( i + 1 ))
     done
     
     exit 1

testing/kuttl/e2e/backup/04--backup-with-longer-option.yaml

@@ -6,7 +6,7 @@ commands:
 
     echo "RESULT from taking backup: ${RESULT}"
 
-    if [[ -n $RESULT && "$RESULT" == "postgresclusters/backup-cluster backup initiated" ]]; then
+    if [ -n "$RESULT" ] && [ "$RESULT" = "postgresclusters/backup-cluster backup initiated" ]; then
         exit 0
     fi
 

testing/kuttl/e2e/backup/05--check-pod-command-with-longer-options.yaml

@@ -6,7 +6,7 @@ commands:
 - script: |
     # Retry getting a successful pod from the most recent backup job.
     # If that pod doesn't have the expected command, sleep and retry
-    for i in {1..10}; do
+    i=1; while [ $i -le 10 ]; do
       BACKUP_COMMAND=$(
           kubectl get pod --namespace "${NAMESPACE}" \
             --output jsonpath="{.items[*].spec.containers[*].env[?(@.name=='COMMAND_OPTS')].value}" \
@@ -19,10 +19,11 @@ commands:
 
       echo "BACKUP_COMMAND found ${BACKUP_COMMAND}"
 
-      if [[ -n $BACKUP_COMMAND && "$BACKUP_COMMAND" == "--stanza=db --repo=1 --type=full --start-fast=y" ]]; then
+      if [ -n "$BACKUP_COMMAND" ] && [ "$BACKUP_COMMAND" = "--stanza=db --repo=1 --type=full --start-fast=y" ]; then
           exit 0
       fi
       sleep 4
+      i=$(( i + 1 ))
     done
     
     exit 1

testing/kuttl/e2e/backup/06--backup-with-multiple-flags.yaml

@@ -6,7 +6,7 @@ commands:
 
     echo "RESULT from taking backup: ${RESULT}"
 
-    if [[ -n $RESULT && "$RESULT" == "postgresclusters/backup-cluster backup initiated" ]]; then
+    if [ -n "$RESULT" ] && [ "$RESULT" = "postgresclusters/backup-cluster backup initiated" ]; then
         exit 0
     fi
 

testing/kuttl/e2e/backup/07--check-pod-command-with-multiple-flags.yaml

@@ -6,7 +6,7 @@ commands:
 - script: |
     # Retry getting a successful pod from the most recent backup job.
     # If that pod doesn't have the expected command, sleep and retry
-    for i in {1..10}; do
+    i=1; while [ $i -le 10 ]; do
       BACKUP_COMMAND=$(
           kubectl get pod --namespace "${NAMESPACE}" \
             --output jsonpath="{.items[*].spec.containers[*].env[?(@.name=='COMMAND_OPTS')].value}" \
@@ -19,10 +19,11 @@ commands:
 
       echo "BACKUP_COMMAND found ${BACKUP_COMMAND}"
 
-      if [[ -n $BACKUP_COMMAND && "$BACKUP_COMMAND" == "--stanza=db --repo=1 --type=full --start-fast=y" ]]; then
+      if [ -n "$BACKUP_COMMAND" ] && [ "$BACKUP_COMMAND" = "--stanza=db --repo=1 --type=full --start-fast=y" ]; then
           exit 0
       fi
       sleep 4
+      i=$(( i + 1 ))
     done
     
     exit 1

testing/kuttl/e2e/backup/08--backup-with-just-trigger.yaml

@@ -1,7 +1,7 @@
 apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
-- script: |    
+- script: |
     pgbackrest_backup_annotation() {
       kubectl get --namespace "${NAMESPACE}" postgrescluster/backup-cluster \
         --output 'go-template={{ index .metadata.annotations "postgres-operator.crunchydata.com/pgbackrest-backup" }}'
@@ -14,13 +14,13 @@ commands:
     CURRENT=$(pgbackrest_backup_annotation)
 
     if [ "${CURRENT}" = "${PRIOR}" ]; then
-      printf 'Expected annotation to change, got %q\n' "${CURRENT}"
+      printf 'Expected annotation to change, got %s\n' "${CURRENT}"
       exit 1
     fi
 
     echo "RESULT from taking backup: ${RESULT}"
 
-    if [[ -n $RESULT && "$RESULT" == "postgresclusters/backup-cluster backup initiated" ]]; then
+    if [ -n "$RESULT" ] && [ "$RESULT" = "postgresclusters/backup-cluster backup initiated" ]; then
         exit 0
     fi
 

testing/kuttl/e2e/backup/11--backup-with-new-flag.yaml

@@ -12,7 +12,17 @@ commands:
       exit 1
     fi
 
-    if [[ "${RESULT,,}" != *conflict* || "${RESULT}" != *repoName* ]]; then
-      printf 'Expected conflict on repoName, got %q\n' "${RESULT}"
-      exit 1
+    # get lowercase for result
+    lower=$(echo "$RESULT" | tr '[:upper:]' '[:lower:]')
+
+    # check for the substring using POSIX compliant parameter-expansion.
+    # If the variable contains the substring after the '%', it does not return
+    # the entire string content, leading to a mismatch. If both substrings are found,
+    # the test passes.
+    # - https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html
+    if [ "${lower}" != "${lower%"conflict"*}" ] && [ "${RESULT}" != "${RESULT%"repoName"*}" ]; then
+      exit 0
     fi
+
+    printf 'Expected conflict on repoName, got %s\n' "${RESULT}"
+    exit 1

testing/kuttl/e2e/backup/12--backup-with-force-conflicts.yaml

@@ -16,13 +16,13 @@ commands:
     CURRENT=$(pgbackrest_backup_annotation)
 
     if [ "${CURRENT}" = "${PRIOR}" ]; then
-      printf 'Expected annotation to change, got %q' "${CURRENT}"
+      printf 'Expected annotation to change, got %s' "${CURRENT}"
       exit 1
     fi
 
     echo "RESULT from taking backup: ${RESULT}"
 
-    if [[ -n $RESULT && "$RESULT" == "postgresclusters/backup-cluster backup initiated" ]]; then
+    if [ -n "$RESULT" ] && [ "$RESULT" = "postgresclusters/backup-cluster backup initiated" ]; then
         exit 0
     fi