Revert version (#84)

* Change PG version back to 14

PG 15 wouldn't work with PGO 5.2, which is our lowest tested version.
Issue: PGO-649

* Add note to enum re: patroni
* Add comment to enum for pgbackrest

Author: benjaminjb

internal/util/enum.go

@@ -24,6 +24,9 @@ import "errors"
 
 // 'patroni list' output format options
 // - https://patroni.readthedocs.io/en/latest/patronictl.html#patronictl-list
+// Note: Patroni has been updated to restrict the input of `--format`,
+// so we can remove this when our lowest supported version of Patroni has this fix.
+// - https://github.com/zalando/patroni/commit/8adddb3467f3c43ddf4ff723a2381e0cf6e2a31b
 type patroniFormat string
 
 const (
@@ -56,6 +59,10 @@ func (e *patroniFormat) Type() string {
 
 // 'pgbackrest info' output format options
 // - https://pgbackrest.org/command.html#command-info
+// `pgbackrest info` does return an error if the output is not an accepted format
+// but without this enum, that error is unclear:
+// Without this enum code: `Error: command terminated with exit code 32`
+// With this enum code: `Error: invalid argument "jsob" for "-o, --output" flag: must be one of "text", "json"`
 type pgbackrestFormat string
 
 const (

testing/kuttl/e2e/backup/00--cluster.yaml

@@ -3,7 +3,7 @@ kind: PostgresCluster
 metadata:
   name: backup-cluster
 spec:
-  postgresVersion: 15
+  postgresVersion: 14
   instances:
     - name: instance1
       dataVolumeClaimSpec:

testing/kuttl/e2e/create/00--create_cluster.yaml

@@ -2,4 +2,4 @@
 apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
-- script: kubectl-pgo --namespace $NAMESPACE create postgrescluster --pg-major-version 15 kuttl-create-cluster
+- script: kubectl-pgo --namespace $NAMESPACE create postgrescluster --pg-major-version 14 kuttl-create-cluster

testing/kuttl/e2e/create/00-assert.yaml

@@ -22,7 +22,7 @@ spec:
           requests:
             storage: 1Gi
       replicas: 1
-  postgresVersion: 15
+  postgresVersion: 14
 status:
   instances:
     - name: "00"

testing/kuttl/e2e/create/01--check_version_validation.yaml

@@ -18,7 +18,7 @@ commands:
      fi
 
      # Verify the error when the Postgres version is not an integer.
-     NOT_INT=$(kubectl-pgo create postgrescluster --pg-major-version=15.1 notint 2>&1)
+     NOT_INT=$(kubectl-pgo create postgrescluster --pg-major-version=14.1 notint 2>&1)
      if [[ "${NOT_INT}" != "Error: invalid argument"* ]]; then
       printf 'Expected invalid argument error, got %q\n' "${NOT_INT}"
       exit 1

testing/kuttl/e2e/delete-cluster/00--cluster.yaml

@@ -3,7 +3,7 @@ kind: PostgresCluster
 metadata:
   name: delete-cluster
 spec:
-  postgresVersion: 15
+  postgresVersion: 14
   instances:
     - name: instance1
       dataVolumeClaimSpec:

testing/kuttl/e2e/restore/00--cluster.yaml

@@ -4,7 +4,7 @@ kind: PostgresCluster
 metadata:
   name: restore-cluster
 spec:
-  postgresVersion: 15
+  postgresVersion: 14
   instances:
     - name: instance1
       dataVolumeClaimSpec:

testing/kuttl/e2e/show/00--cluster.yaml

@@ -3,7 +3,7 @@ kind: PostgresCluster
 metadata:
   name: show-cluster
 spec:
-  postgresVersion: 15
+  postgresVersion: 14
   instances:
     - name: instance1
       dataVolumeClaimSpec:

testing/kuttl/e2e/support-export/00--create_cluster.yaml

@@ -2,4 +2,4 @@
 apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
-- script: kubectl-pgo --namespace $NAMESPACE create postgrescluster --pg-major-version 15 kuttl-support-cluster
+- script: kubectl-pgo --namespace $NAMESPACE create postgrescluster --pg-major-version 14 kuttl-support-cluster

testing/kuttl/e2e/support-export/00-assert.yaml

@@ -22,7 +22,7 @@ spec:
           requests:
             storage: 1Gi
       replicas: 1
-  postgresVersion: 15
+  postgresVersion: 14
 status:
   instances:
     - name: "00"