FIXUP: reject replica for now

Author: cbandy

config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml

@@ -4718,7 +4718,7 @@ spec:
                     - message: domain socket paths cannot be changed
                       rule: '!self.exists(k, k.startsWith("unix_socket_"))'
                     - message: wal_level must be "replica" or higher
-                      rule: '!has(self.wal_level) || self.wal_level in ["replica","logical"]'
+                      rule: '!has(self.wal_level) || self.wal_level in ["logical"]'
                     - message: wal_log_hints are always enabled
                       rule: '!has(self.wal_log_hints)'
                     - rule: '!has(self.archive_mode) && !has(self.archive_command)

internal/testing/validation/postgrescluster_test.go

@@ -163,11 +163,6 @@ func TestPostgresConfigParameters(t *testing.T) {
 				"wal_level": intstr.FromString("logical"),
 			}
 			assert.NilError(t, cc.Create(ctx, cluster, client.DryRunAll))
-
-			cluster.Spec.Config.Parameters = map[string]intstr.IntOrString{
-				"wal_level": intstr.FromString("replica"),
-			}
-			assert.NilError(t, cc.Create(ctx, cluster, client.DryRunAll))
 		})
 
 		t.Run("Invalid", func(t *testing.T) {

pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgres_types.go

@@ -43,7 +43,7 @@ type PostgresConfig struct {
 	// # Write Ahead Log
 	// - https://www.postgresql.org/docs/current/runtime-config-wal.html
 	//
-	// +kubebuilder:validation:XValidation:rule=`!has(self.wal_level) || self.wal_level in ["replica","logical"]`,message=`wal_level must be "replica" or higher`
+	// +kubebuilder:validation:XValidation:rule=`!has(self.wal_level) || self.wal_level in ["logical"]`,message=`wal_level must be "replica" or higher`
 	// +kubebuilder:validation:XValidation:rule=`!has(self.wal_log_hints)`,message=`wal_log_hints are always enabled`
 	// +kubebuilder:validation:XValidation:rule=`!has(self.archive_mode) && !has(self.archive_command) && !has(self.restore_command)`
 	// +kubebuilder:validation:XValidation:rule=`!has(self.recovery_target) && !self.exists(k, k.startsWith("recovery_target_"))`