Skip to content

Commit 1042175

Browse files
jmckulkJonathan S. Katz
authored andcommitted
Updates operator to set service ports as env vars.
Currently pgbadger and postgres-exporter service ports are used to create the service but not passed into the container. This update changes the deployment json files so that the service ports are set in the environment of the container. The ports defined in the pgo-config are passed into the deployment templates and used to create the containers.
1 parent 0d738ca commit 1042175

File tree

5 files changed

+33
-16
lines changed

5 files changed

+33
-16
lines changed

ansible/roles/pgo-operator/files/pgo-configs/collect.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "collect",
33
"image": "{{.CCPImagePrefix}}/crunchy-collect:{{.CCPImageTag}}",
44
"ports": [{
5-
"containerPort": 9187,
5+
"containerPort": {{.ExporterPort}},
66
"protocol": "TCP"
77
}],
88
"env": [
@@ -25,6 +25,10 @@
2525
{
2626
"name": "JOB_NAME",
2727
"value": "{{.JobName}}"
28+
},
29+
{
30+
"name": "POSTGRES_EXPORTER_PORT",
31+
"value": "{{.ExporterPort}}"
2832
}
2933
],
3034
"volumeMounts": [

ansible/roles/pgo-operator/files/pgo-configs/pgbadger.json

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,26 @@
11
,{
22
"name": "pgbadger",
3-
"image": "{{.CCPImagePrefix}}/crunchy-pgbadger:{{.CCPImageTag}}",
3+
"image": "{{.CCPImagePrefix}}/crunchy-pgbadger:{{.CCPImageTag}}",
44
"ports": [ {
5-
"containerPort": 10000,
5+
"containerPort": {{.PGBadgerPort}},
66
"protocol": "TCP"
77
}
88
],
99
"readinessProbe": {
1010
"tcpSocket": {
11-
"port": 10000
11+
"port": {{.PGBadgerPort}}
1212
},
1313
"initialDelaySeconds": 20,
1414
"periodSeconds": 10
1515
},
16-
{{.ContainerResources }}
16+
{{.ContainerResources }}
1717
"env": [ {
18-
"name": "BADGER_TARGET",
19-
"value": "{{.BadgerTarget}}"
20-
} ],
18+
"name": "BADGER_TARGET",
19+
"value": "{{.BadgerTarget}}"
20+
},{
21+
"name": "PGBADGER_SERVICE_PORT",
22+
"value": "{{.PGBadgerPort}}"
23+
} ],
2124
"volumeMounts": [
2225
{
2326
"mountPath": "/pgdata",

conf/postgres-operator/collect.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "collect",
33
"image": "{{.CCPImagePrefix}}/crunchy-collect:{{.CCPImageTag}}",
44
"ports": [{
5-
"containerPort": 9187,
5+
"containerPort": {{.ExporterPort}},
66
"protocol": "TCP"
77
}],
88
"env": [
@@ -25,6 +25,9 @@
2525
{
2626
"name": "JOB_NAME",
2727
"value": "{{.JobName}}"
28+
},{
29+
"name": "POSTGRES_EXPORTER_PORT",
30+
"value": "{{.ExporterPort}}"
2831
}
2932
],
3033
"volumeMounts": [

conf/postgres-operator/pgbadger.json

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,26 @@
11
,{
22
"name": "pgbadger",
3-
"image": "{{.CCPImagePrefix}}/crunchy-pgbadger:{{.CCPImageTag}}",
3+
"image": "{{.CCPImagePrefix}}/crunchy-pgbadger:{{.CCPImageTag}}",
44
"ports": [ {
5-
"containerPort": 10000,
5+
"containerPort": {{.PGBadgerPort}},
66
"protocol": "TCP"
77
}
88
],
99
"readinessProbe": {
1010
"tcpSocket": {
11-
"port": 10000
11+
"port": {{.PGBadgerPort}}
1212
},
1313
"initialDelaySeconds": 20,
1414
"periodSeconds": 10
1515
},
16-
{{.ContainerResources }}
16+
{{.ContainerResources }}
1717
"env": [ {
18-
"name": "BADGER_TARGET",
19-
"value": "{{.BadgerTarget}}"
20-
} ],
18+
"name": "BADGER_TARGET",
19+
"value": "{{.BadgerTarget}}"
20+
}, {
21+
"name": "PGBADGER_SERVICE_PORT",
22+
"value": "{{.PGBadgerPort}}"
23+
} ],
2124
"volumeMounts": [
2225
{
2326
"mountPath": "/pgdata",

operator/clusterutilities.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,15 @@ type collectTemplateFields struct {
5050
CCPImageTag string
5151
CCPImagePrefix string
5252
PgPort string
53+
ExporterPort string
5354
}
5455

5556
//consolidate
5657
type badgerTemplateFields struct {
5758
CCPImageTag string
5859
CCPImagePrefix string
5960
BadgerTarget string
61+
PGBadgerPort string
6062
ContainerResources string
6163
}
6264

@@ -158,6 +160,7 @@ func GetBadgerAddon(clientset *kubernetes.Clientset, namespace string, cluster *
158160
badgerTemplateFields := badgerTemplateFields{}
159161
badgerTemplateFields.CCPImageTag = spec.CCPImageTag
160162
badgerTemplateFields.BadgerTarget = pgbadger_target
163+
badgerTemplateFields.PGBadgerPort = spec.PGBadgerPort
161164
badgerTemplateFields.CCPImagePrefix = Pgo.Cluster.CCPImagePrefix
162165
badgerTemplateFields.ContainerResources = ""
163166

@@ -199,6 +202,7 @@ func GetCollectAddon(clientset *kubernetes.Clientset, namespace string, spec *cr
199202
collectTemplateFields.Name = spec.Name
200203
collectTemplateFields.JobName = spec.Name
201204
collectTemplateFields.CCPImageTag = spec.CCPImageTag
205+
collectTemplateFields.ExporterPort = spec.ExporterPort
202206
collectTemplateFields.CCPImagePrefix = Pgo.Cluster.CCPImagePrefix
203207
collectTemplateFields.PgPort = spec.Port
204208

0 commit comments

Comments
 (0)