update backup error messages back to the pgo user, make them clearer

Author: Jeff McCormick

apiserver/backupservice/backupimpl.go

@@ -119,7 +119,7 @@ func CreateBackup(request *msgs.CreateBackupRequest) msgs.CreateBackupResponse {
 
 		if len(clusterList.Items) == 0 {
 			log.Debug("no clusters found")
-			resp.Status.Msg = "no clusters found"
+			resp.Results = append(resp.Results, "no clusters found with that selector")
 			return resp
 		} else {
 			newargs := make([]string, 0)
@@ -130,16 +130,29 @@ func CreateBackup(request *msgs.CreateBackupRequest) msgs.CreateBackupResponse {
 		}
 
 	}
+
 	for _, arg := range request.Args {
 		log.Debug("create backup called for " + arg)
 
+		cluster := crv1.Pgcluster{}
+		found, err := kubeapi.Getpgcluster(apiserver.RESTClient, &cluster, arg, apiserver.Namespace)
+		if !found {
+			resp.Status.Code = msgs.Error
+			resp.Status.Msg = arg + " was not found, verify cluster name"
+			return resp
+		} else if err != nil {
+			resp.Status.Code = msgs.Error
+			resp.Status.Msg = err.Error()
+			return resp
+		}
+
 		//remove any existing backup job
 		RemoveBackupJob("backup-" + arg)
 
 		result := crv1.Pgbackup{}
 
 		// error if it already exists
-		found, err := kubeapi.Getpgbackup(apiserver.RESTClient, &result, arg, apiserver.Namespace)
+		found, err = kubeapi.Getpgbackup(apiserver.RESTClient, &result, arg, apiserver.Namespace)
 		if !found {
 			log.Debug("pgbackup " + arg + " not found so we create it")
 		} else if err != nil {

kubeapi/pgcluster.go

@@ -47,6 +47,9 @@ func GetpgclustersBySelector(client *rest.RESTClient, clusterList *crv1.Pgcluste
 		Param("labelSelector", myselector.String()).
 		Do().
 		Into(clusterList)
+	if kerrors.IsNotFound(err) {
+		log.Debug("clusters for  " + myselector.String() + " not found")
+	}
 	if err != nil {
 		log.Error("error getting list of clusters " + err.Error())
 	}

pgo/cmd/backup.go

@@ -238,7 +238,7 @@ func createBackup(args []string) {
 	}
 
 	if len(response.Results) == 0 {
-		fmt.Println("no backups found")
+		fmt.Println("no clusters found")
 		return
 	}