fix backup command to return proper error message if the user tries to perform a pgbackrest backup on a cluster that does not have pgbackrest enabled

Author: jmccormick2001

apiserver/backrestservice/backrestimpl.go

@@ -84,6 +84,12 @@ func CreateBackup(request *msgs.CreateBackrestBackupRequest) msgs.CreateBackrest
 			return resp
 		}
 
+		if cluster.Spec.UserLabels[util.LABEL_BACKREST] != "true" {
+			resp.Status.Code = msgs.Error
+			resp.Status.Msg = clusterName + " does not have pgbackrest enabled"
+			return resp
+		}
+
 		result := crv1.Pgtask{}
 
 		// error if it already exists

apiserver/clusterservice/clusterimpl.go

@@ -795,7 +795,7 @@ func getClusterParams(request *msgs.CreateClusterRequest, name string, userLabel
 	spec.RootPassword = request.Password
 	spec.Replicas = "0"
 	str := apiserver.Pgo.Cluster.Replicas
-	log.Debugf("%s is the pgo.yaml replicas setting", apiserver.Pgo.Cluster.Replicas)
+	log.Debugf("[%s] is Pgo.Cluster.Replicas", str)
 	if str != "" {
 		spec.Replicas = str
 	}

pgo/cmd/cluster.go

@@ -169,7 +169,7 @@ func createCluster(args []string) {
 
 	r := new(msgs.CreateClusterRequest)
 	r.Name = args[0]
-	r.ReplicaCount = ReplicaCount
+	r.ReplicaCount = ClusterReplicaCount
 	r.NodeLabel = NodeLabel
 	r.Password = Password
 	r.SecretFrom = SecretFrom

pgo/cmd/create.go

@@ -22,6 +22,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
+var ClusterReplicaCount int
 var ManagedUser bool
 var ContainerResources string
 var ReplicaStorageConfig, StorageConfig string
@@ -245,7 +246,7 @@ func init() {
 	createClusterCmd.Flags().StringVarP(&PoliciesFlag, "policies", "z", "", "The policies to apply when creating a cluster, comma separated.")
 	createClusterCmd.Flags().StringVarP(&CCPImageTag, "ccp-image-tag", "c", "", "The CCPImageTag to use for cluster creation. If specified, overrides the pgo.yaml setting.")
 	createClusterCmd.Flags().IntVarP(&Series, "series", "e", 1, "The number of clusters to create in a series.")
-	createClusterCmd.Flags().IntVarP(&ReplicaCount, "replica-count", "", 0, "The number of replicas to create as part of the cluster.")
+	createClusterCmd.Flags().IntVarP(&ClusterReplicaCount, "replica-count", "", 0, "The number of replicas to create as part of the cluster.")
 	createClusterCmd.Flags().StringVarP(&ContainerResources, "resources-config", "r", "", "The name of a container resource configuration in pgo.yaml that holds CPU and memory requests and limits.")
 
 	createIngestCmd.Flags().StringVarP(&IngestConfig, "ingest-config", "i", "", "Defines the path of an ingest configuration file.")