The InstanceSidecars Feature Gate Now Defaults to Enabled

Issue: PGO-2269

Author: andrewlecuyer

internal/feature/features.go

@@ -109,7 +109,7 @@ func NewGate() MutableGate {
 		AutoCreateUserSchema:    {Default: true, PreRelease: featuregate.Beta},
 		AutoGrowVolumes:         {Default: false, PreRelease: featuregate.Alpha},
 		BridgeIdentifiers:       {Default: false, PreRelease: featuregate.Deprecated},
-		InstanceSidecars:        {Default: false, PreRelease: featuregate.Alpha},
+		InstanceSidecars:        {Default: true, PreRelease: featuregate.Alpha},
 		OpenTelemetryLogs:       {Default: false, PreRelease: featuregate.Alpha},
 		OpenTelemetryMetrics:    {Default: false, PreRelease: featuregate.Alpha},
 		PGBouncerSidecars:       {Default: false, PreRelease: featuregate.Alpha},

internal/feature/features_test.go

@@ -20,7 +20,7 @@ func TestDefaults(t *testing.T) {
 	assert.Assert(t, true == gate.Enabled(AutoCreateUserSchema))
 	assert.Assert(t, false == gate.Enabled(AutoGrowVolumes))
 	assert.Assert(t, false == gate.Enabled(BridgeIdentifiers))
-	assert.Assert(t, false == gate.Enabled(InstanceSidecars))
+	assert.Assert(t, true == gate.Enabled(InstanceSidecars))
 	assert.Assert(t, false == gate.Enabled(OpenTelemetryLogs))
 	assert.Assert(t, false == gate.Enabled(OpenTelemetryMetrics))
 	assert.Assert(t, false == gate.Enabled(PGBouncerSidecars))

internal/upgradecheck/http_test.go

@@ -67,7 +67,8 @@ func TestCheckForUpgrades(t *testing.T) {
 		assert.Equal(t, data.RegistrationToken, "speakFriend")
 		assert.Equal(t, data.BridgeClustersTotal, 2)
 		assert.Equal(t, data.PGOClustersTotal, 2)
-		assert.Equal(t, data.FeatureGatesEnabled, "AutoCreateUserSchema=true,PGUpgradeCPUConcurrency=true,TablespaceVolumes=true")
+		assert.Equal(t, data.FeatureGatesEnabled,
+			"AutoCreateUserSchema=true,InstanceSidecars=true,PGUpgradeCPUConcurrency=true,TablespaceVolumes=true")
 	}
 
 	t.Run("success", func(t *testing.T) {