Skip to content

Commit 2ced929

Browse files
author
jmccormick2001
committed
fix resources-config for replicas to match either the cluster resources config or the resources-config on the scale command
1 parent 5e88d4b commit 2ced929

File tree

2 files changed

+34
-26
lines changed

2 files changed

+34
-26
lines changed

operator/cluster/cluster.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ func AddClusterBase(clientset *kubernetes.Clientset, client *rest.RESTClient, cl
237237
for i := 0; i < replicaCount; i++ {
238238
spec := crv1.PgreplicaSpec{}
239239
//get the resource config
240+
spec.ContainerResources = cl.Spec.ContainerResources
240241
//get the storage config
241242
spec.ReplicaStorage, _ = operator.Pgo.GetStorageSpec(operator.Pgo.ReplicaStorage)
242243

operator/cluster/cluster_strategy_1.go

Lines changed: 33 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -557,34 +557,41 @@ func (r Strategy1) Scale(clientset *kubernetes.Clientset, client *rest.RESTClien
557557
imageTag = replica.Spec.UserLabels[util.LABEL_CCP_IMAGE_TAG_KEY]
558558
}
559559

560+
//allow the user to override the replica resources
561+
cs := replica.Spec.ContainerResources
562+
if replica.Spec.ContainerResources.LimitsCPU == "" {
563+
cs = cluster.Spec.ContainerResources
564+
}
565+
560566
//create the replica deployment
561567
replicaDeploymentFields := DeploymentTemplateFields{
562-
Name: replica.Spec.Name,
563-
ClusterName: replica.Spec.ClusterName,
564-
PgMode: "replica",
565-
Port: cluster.Spec.Port,
566-
CCPImagePrefix: operator.Pgo.Cluster.CCPImagePrefix,
567-
CCPImageTag: imageTag,
568-
PVCName: util.CreatePVCSnippet(cluster.Spec.ReplicaStorage.StorageType, pvcName),
569-
BackupPVCName: util.CreateBackupPVCSnippet(cluster.Spec.BackupPVCName),
570-
PrimaryHost: cluster.Spec.PrimaryHost,
571-
BackupPath: "",
572-
Database: cluster.Spec.Database,
573-
DataPathOverride: replica.Spec.Name,
574-
ArchiveMode: archiveMode,
575-
ArchivePVCName: util.CreateBackupPVCSnippet(archivePVCName),
576-
BackrestPVCName: util.CreateBackrestPVCSnippet(backrestPVCName),
577-
ArchiveTimeout: archiveTimeout,
578-
Replicas: "1",
579-
ConfVolume: GetConfVolume(clientset, cluster.Spec.CustomConfig, namespace),
580-
OperatorLabels: util.GetLabelsFromMap(replicaLabels),
581-
SecurityContext: util.CreateSecContext(replica.Spec.ReplicaStorage.Fsgroup, replica.Spec.ReplicaStorage.SupplementalGroups),
582-
RootSecretName: cluster.Spec.RootSecretName,
583-
PrimarySecretName: cluster.Spec.PrimarySecretName,
584-
UserSecretName: cluster.Spec.UserSecretName,
585-
NodeSelector: GetReplicaAffinity(cluster.Spec.UserLabels, replica.Spec.UserLabels),
586-
CollectAddon: GetCollectAddon(clientset, namespace, &cluster.Spec),
587-
BadgerAddon: GetBadgerAddon(clientset, namespace, &cluster.Spec),
568+
Name: replica.Spec.Name,
569+
ClusterName: replica.Spec.ClusterName,
570+
PgMode: "replica",
571+
Port: cluster.Spec.Port,
572+
CCPImagePrefix: operator.Pgo.Cluster.CCPImagePrefix,
573+
CCPImageTag: imageTag,
574+
PVCName: util.CreatePVCSnippet(cluster.Spec.ReplicaStorage.StorageType, pvcName),
575+
BackupPVCName: util.CreateBackupPVCSnippet(cluster.Spec.BackupPVCName),
576+
PrimaryHost: cluster.Spec.PrimaryHost,
577+
BackupPath: "",
578+
Database: cluster.Spec.Database,
579+
DataPathOverride: replica.Spec.Name,
580+
ArchiveMode: archiveMode,
581+
ArchivePVCName: util.CreateBackupPVCSnippet(archivePVCName),
582+
BackrestPVCName: util.CreateBackrestPVCSnippet(backrestPVCName),
583+
ArchiveTimeout: archiveTimeout,
584+
Replicas: "1",
585+
ConfVolume: GetConfVolume(clientset, cluster.Spec.CustomConfig, namespace),
586+
OperatorLabels: util.GetLabelsFromMap(replicaLabels),
587+
SecurityContext: util.CreateSecContext(replica.Spec.ReplicaStorage.Fsgroup, replica.Spec.ReplicaStorage.SupplementalGroups),
588+
RootSecretName: cluster.Spec.RootSecretName,
589+
PrimarySecretName: cluster.Spec.PrimarySecretName,
590+
UserSecretName: cluster.Spec.UserSecretName,
591+
ContainerResources: GetContainerResources(&cs),
592+
NodeSelector: GetReplicaAffinity(cluster.Spec.UserLabels, replica.Spec.UserLabels),
593+
CollectAddon: GetCollectAddon(clientset, namespace, &cluster.Spec),
594+
BadgerAddon: GetBadgerAddon(clientset, namespace, &cluster.Spec),
588595
}
589596

590597
switch replica.Spec.ReplicaStorage.StorageType {

0 commit comments

Comments
 (0)