Revert conversion of installer switches

Jonathan S. Katz · jkatz · commit 5b2be2b77a91 · 2020-07-16T15:00:40.000-04:00
While with good intentions, this had too many unintended side-effects and will be addressed as part of the next release cycle. This fully reverts 577b387 and 1b037b0 and is a partial revert of cd53751.
diff --git a/installers/ansible/values.yaml b/installers/ansible/values.yaml
@@ -1,5 +1,5 @@
 ---
-archive_mode: true
+archive_mode: "true"
 archive_timeout: "60"
 backrest_aws_s3_bucket: ""
 backrest_aws_s3_endpoint: ""
@@ -9,13 +9,13 @@ backrest_aws_s3_secret: ""
 backrest_aws_s3_uri_style: ""
 backrest_aws_s3_verify_tls: true
 backrest_port: "2022"
-badger: false
+badger: "false"
 ccp_image_prefix: "registry.developers.crunchydata.com/crunchydata"
 ccp_image_pull_secret: ""
 ccp_image_pull_secret_manifest: ""
 ccp_image_tag: "centos7-12.3-4.4.0-rc.1"
-create_rbac: true
-crunchy_debug: false
+create_rbac: "true"
+crunchy_debug: "false"
 db_name: ""
 db_password_age_days: "0"
 db_password_length: "24"
@@ -25,38 +25,38 @@ db_user: "testuser"
 default_instance_memory: "128Mi"
 default_pgbackrest_memory: "48Mi"
 default_pgbouncer_memory: "24Mi"
-delete_metrics_namespace: false
-delete_operator_namespace: false
-delete_watched_namespaces: false
-disable_auto_failover: false
-disable_fsgroup: false
-reconcile_rbac: true
+delete_metrics_namespace: "false"
+delete_operator_namespace: "false"
+delete_watched_namespaces: "false"
+disable_auto_failover: "false"
+disable_fsgroup: "false"
+reconcile_rbac: "true"
 exporterport: "9187"
 grafana_admin_password: ""
 grafana_admin_username: "admin"
-grafana_install: false
+grafana_install: "false"
 grafana_storage_access_mode: "ReadWriteOnce"
 grafana_storage_class_name: "fast"
 grafana_supplemental_groups: "65534"
 grafana_volume_size: "1G"
-metrics: false
+metrics: "false"
 metrics_namespace: "pgo"
 namespace: "pgo"
 namespace_mode: "dynamic"
 pgbadgerport: "10000"
-pgo_add_os_ca_store: false
+pgo_add_os_ca_store: "false"
 pgo_admin_password: "examplepassword"
 pgo_admin_perms: "*"
 pgo_admin_role_name: "pgoadmin"
 pgo_admin_username: "admin"
 pgo_apiserver_port: "8443"
 pgo_apiserver_url: "https://postgres-operator"
 pgo_client_cert_secret: "pgo.tls"
-pgo_client_container_install: false
+pgo_client_container_install: "false"
 pgo_client_version: "v4.4.0-rc.1"
-pgo_cluster_admin: false
-pgo_disable_eventing: false
-pgo_disable_tls: false
+pgo_cluster_admin: "false"
+pgo_disable_eventing: "false"
+pgo_disable_tls: "false"
 pgo_image_prefix: "registry.developers.crunchydata.com/crunchydata"
 pgo_image_pull_secret: ""
 pgo_image_pull_secret_manifest: ""
@@ -65,18 +65,18 @@ pgo_installation_name: "devtest"
 pgo_noauth_routes: ""
 pgo_operator_namespace: "pgo"
 pgo_tls_ca_store: ""
-pgo_tls_no_verify: false
+pgo_tls_no_verify: "false"
 pod_anti_affinity: "preferred"
 pod_anti_affinity_pgbackrest: ""
 pod_anti_affinity_pgbouncer: ""
-prometheus_install: false
+prometheus_install: "false"
 prometheus_storage_access_mode: "ReadWriteOnce"
 prometheus_storage_class_name: "fast"
 prometheus_supplemental_groups: "65534"
 prometheus_volume_size: "1G"
 scheduler_timeout: "3600"
 service_type: "ClusterIP"
-sync_replication: false
+sync_replication: "false"
 backrest_storage: "hostpathstorage"
 backup_storage: "hostpathstorage"
 primary_storage: "hostpathstorage"
diff --git a/installers/helm/metrics/templates/values_configmap.yaml b/installers/helm/metrics/templates/values_configmap.yaml
@@ -8,33 +8,33 @@ metadata:
 data:
   values.yaml: |
     ---
-    archive_mode: {{ .Values.archive_mode}}
+    archive_mode: "{{ .Values.archive_mode}}"
     archive_timeout: "{{ .Values.archive_timeout}}"
-    badger: {{ .Values.badger}}
+    badger: "{{ .Values.badger}}"
     ccp_image_prefix: "{{ .Values.ccp_image_prefix}}"
     ccp_image_pull_secret: "{{ .Values.ccp_image_pull_secret}}"
     ccp_image_pull_secret_manifest: "{{ .Values.ccp_image_pull_secret_manifest}}"
     ccp_image_tag: "{{ .Values.ccp_image_tag}}"
-    create_rbac: {{ .Values.create_rbac}}
-    crunchy_debug: {{ .Values.crunchy_debug}}
+    create_rbac: "{{ .Values.create_rbac}}"
+    crunchy_debug: "{{ .Values.crunchy_debug}}"
     db_password_age_days: "{{ .Values.db_password_age_days}}"
     db_password_length: "{{ .Values.db_password_length}}"
     db_port: "{{ .Values.db_port}}"
     db_replicas: "{{ .Values.db_replicas}}"
     db_user: "{{ .Values.db_user}}"
-    delete_metrics_namespace: {{ .Values.delete_metrics_namespace}}
-    disable_auto_failover: {{ .Values.disable_auto_failover}}
-    disable_fsgroup: {{ .Values.disable_fsgroup}}
-    reconcile_rbac: {{ .Values.reconcile_rbac}}
+    delete_metrics_namespace: "{{ .Values.delete_metrics_namespace}}"
+    disable_auto_failover: "{{ .Values.disable_auto_failover}}"
+    disable_fsgroup: "{{ .Values.disable_fsgroup}}"
+    reconcile_rbac: "{{ .Values.reconcile_rbac}}"
     exporterport: "{{ .Values.exporterport}}"
     grafana_admin_password: "{{ .Values.grafana_admin_password}}"
     grafana_admin_username: "{{ .Values.grafana_admin_username}}"
-    grafana_install: {{ .Values.grafana_install}}
+    grafana_install: "{{ .Values.grafana_install}}"
     grafana_storage_access_mode: "{{ .Values.grafana_storage_access_mode}}"
     grafana_storage_class_name: "{{ .Values.grafana_storage_class_name}}"
     grafana_supplemental_groups: "{{ .Values.grafana_supplemental_groups}}"
     grafana_volume_size: "{{ .Values.grafana_volume_size}}"
-    metrics: {{ .Values.metrics}}
+    metrics: "{{ .Values.metrics}}"
     metrics_namespace: "{{ .Values.metrics_namespace}}"
     namespace_mode: "{{ .Values.namespace_mode}}"
     pgbadgerport: "{{ .Values.pgbadgerport}}"
@@ -49,7 +49,7 @@ data:
     pgo_image_tag: "{{ .Values.pgo_image_tag}}"
     pgo_installation_name: "{{ .Values.pgo_installation_name}}"
     pgo_operator_namespace: "{{ .Values.pgo_operator_namespace}}"
-    prometheus_install: {{ .Values.prometheus_install}}
+    prometheus_install: "{{ .Values.prometheus_install}}"
     prometheus_storage_access_mode: "{{ .Values.prometheus_storage_access_mode}}"
     prometheus_storage_class_name: "{{ .Values.prometheus_storage_class_name}}"
     prometheus_supplemental_groups: "{{ .Values.prometheus_supplemental_groups}}"
diff --git a/installers/helm/metrics/values.yaml b/installers/helm/metrics/values.yaml
@@ -23,32 +23,32 @@ serviceAccount:
 # More info for these options can be found in the docs
 # https://crunchydata.github.io/postgres-operator/latest/installation/configuration/
 # =====================
-archive_mode: true
+archive_mode: "true"
 archive_timeout: "60"
-badger: false
+badger: "false"
 ccp_image_prefix: "registry.developers.crunchydata.com/crunchydata"
 ccp_image_pull_secret: ""
 ccp_image_pull_secret_manifest: ""
 ccp_image_tag: "centos7-12.3-4.4.0-rc.1"
-create_rbac: true
-crunchy_debug: false
+create_rbac: "true"
+crunchy_debug: "false"
 db_password_length: "24"
 db_port: "5432"
 db_replicas: "0"
 db_user: "testuser"
-delete_metrics_namespace: false
-disable_auto_failover: false
-disable_fsgroup: false
-reconcile_rbac: true
+delete_metrics_namespace: "false"
+disable_auto_failover: "false"
+disable_fsgroup: "false"
+reconcile_rbac: "true"
 exporterport: "9187"
 grafana_admin_password: ""
 grafana_admin_username: "admin"
-grafana_install: false
+grafana_install: "false"
 grafana_storage_access_mode: "ReadWriteOnce"
 grafana_storage_class_name: "fast"
 grafana_supplemental_groups: "65534"
 grafana_volume_size: "1G"
-metrics: false
+metrics: "false"
 metrics_namespace: "pgo"
 namespace_mode: "dynamic"
 pgbadgerport: "10000"
@@ -63,7 +63,7 @@ pgo_image_pull_secret_manifest: ""
 pgo_image_tag: "centos7-4.4.0-rc.1"
 pgo_installation_name: "devtest"
 pgo_operator_namespace: "pgo"
-prometheus_install: false
+prometheus_install: "false"
 prometheus_storage_access_mode: "ReadWriteOnce"
 prometheus_storage_class_name: "fast"
 prometheus_supplemental_groups: "65534"
diff --git a/installers/helm/postgres-operator/templates/values_configmap.yaml b/installers/helm/postgres-operator/templates/values_configmap.yaml
@@ -8,23 +8,23 @@ metadata:
 data:
   values.yaml: |
     ---
-    archive_mode: {{ .Values.archive_mode}}
+    archive_mode: "{{ .Values.archive_mode}}"
     archive_timeout: "{{ .Values.archive_timeout}}"
     backrest_aws_s3_bucket: "{{ .Values.backrest_aws_s3_bucket}}"
     backrest_aws_s3_endpoint: "{{ .Values.backrest_aws_s3_endpoint}}"
     backrest_aws_s3_key: "{{ .Values.backrest_aws_s3_key}}"
     backrest_aws_s3_region: "{{ .Values.backrest_aws_s3_region}}"
     backrest_aws_s3_secret: "{{ .Values.backrest_aws_s3_secret}}"
     backrest_aws_s3_uri_style: "{{ .Values.backrest_aws_s3_uri_style }}"
-    backrest_aws_s3_verify_tls: {{ .Values.backrest_aws_s3_verify_tls }}
+    backrest_aws_s3_verify_tls: "{{ .Values.backrest_aws_s3_verify_tls }}"
     backrest_port: "{{ .Values.backrest_port}}"
-    badger: {{ .Values.badger}}
+    badger: "{{ .Values.badger}}"
     ccp_image_prefix: "{{ .Values.ccp_image_prefix}}"
     ccp_image_pull_secret: "{{ .Values.ccp_image_pull_secret}}"
     ccp_image_pull_secret_manifest: "{{ .Values.ccp_image_pull_secret_manifest}}"
     ccp_image_tag: "{{ .Values.ccp_image_tag}}"
-    create_rbac: {{ .Values.create_rbac}}
-    crunchy_debug: {{ .Values.crunchy_debug}}
+    create_rbac: "{{ .Values.create_rbac}}"
+    crunchy_debug: "{{ .Values.crunchy_debug}}"
     db_name: "{{ .Values.db_name}}"
     db_password_age_days: "{{ .Values.db_password_age_days}}"
     db_password_length: "{{ .Values.db_password_length}}"
@@ -34,30 +34,30 @@ data:
     default_instance_memory: "{{ .Values.default_instance_memory}}"
     default_pgbackrest_memory: "{{ .Values.default_pgbackrest_memory}}"
     default_pgbouncer_memory: "{{ .Values.default_pgbouncer_memory}}"
-    delete_metrics_namespace: {{ .Values.delete_metrics_namespace}}
-    delete_operator_namespace: {{ .Values.delete_operator_namespace}}
-    delete_watched_namespaces: {{ .Values.delete_watched_namespaces}}
-    disable_auto_failover: {{ .Values.disable_auto_failover}}
-    disable_fsgroup: {{ .Values.disable_fsgroup}}
-    reconcile_rbac: {{ .Values.reconcile_rbac}}
+    delete_metrics_namespace: "{{ .Values.delete_metrics_namespace}}"
+    delete_operator_namespace: "{{ .Values.delete_operator_namespace}}"
+    delete_watched_namespaces: "{{ .Values.delete_watched_namespaces}}"
+    disable_auto_failover: "{{ .Values.disable_auto_failover}}"
+    disable_fsgroup: "{{ .Values.disable_fsgroup}}"
+    reconcile_rbac: "{{ .Values.reconcile_rbac}}"
     exporterport: "{{ .Values.exporterport}}"
-    metrics: {{ .Values.metrics}}
+    metrics: "{{ .Values.metrics}}"
     namespace: "{{ .Values.namespace}}"
     namespace_mode: "{{ .Values.namespace_mode}}"
     pgbadgerport: "{{ .Values.pgbadgerport}}"
-    pgo_add_os_ca_store: {{ .Values.pgo_add_os_ca_store}}
+    pgo_add_os_ca_store: "{{ .Values.pgo_add_os_ca_store}}"
     pgo_admin_password: "{{ .Values.pgo_admin_password}}"
     pgo_admin_perms: "{{ .Values.pgo_admin_perms}}"
     pgo_admin_role_name: "{{ .Values.pgo_admin_role_name}}"
     pgo_admin_username: "{{ .Values.pgo_admin_username}}"
     pgo_apiserver_port: "{{ .Values.pgo_apiserver_port}}"
     pgo_apiserver_url: "{{ .Values.pgo_apiserver_url}}"
     pgo_client_cert_secret: "{{ .Values.pgo_client_cert_secret}}"
-    pgo_client_container_install: {{ .Values.pgo_client_container_install}}
+    pgo_client_container_install: "{{ .Values.pgo_client_container_install}}"
     pgo_client_version: "{{ .Values.pgo_client_version}}"
-    pgo_cluster_admin: {{ .Values.pgo_cluster_admin}}
-    pgo_disable_eventing: {{ .Values.pgo_disable_eventing}}
-    pgo_disable_tls: {{ .Values.pgo_disable_tls}}
+    pgo_cluster_admin: "{{ .Values.pgo_cluster_admin}}"
+    pgo_disable_eventing: "{{ .Values.pgo_disable_eventing}}"
+    pgo_disable_tls: "{{ .Values.pgo_disable_tls}}"
     pgo_image_prefix: "{{ .Values.pgo_image_prefix}}"
     pgo_image_pull_secret: "{{ .Values.pgo_image_pull_secret}}"
     pgo_image_pull_secret_manifest: "{{ .Values.pgo_image_pull_secret_manifest}}"
@@ -66,13 +66,13 @@ data:
     pgo_noauth_routes: "{{ .Values.pgo_noauth_routes}}"
     pgo_operator_namespace: "{{ .Values.pgo_operator_namespace}}"
     pgo_tls_ca_store: "{{ .Values.pgo_tls_ca_store}}"
-    pgo_tls_no_verify: {{ .Values.pgo_tls_no_verify}}
+    pgo_tls_no_verify: "{{ .Values.pgo_tls_no_verify}}"
     pod_anti_affinity: "{{ .Values.pod_anti_affinity}}"
     pod_anti_affinity_pgbackrest: "{{ .Values.pod_anti_affinity_pgbackrest}}"
     pod_anti_affinity_pgbouncer: "{{ .Values.pod_anti_affinity_pgbouncer}}"
     scheduler_timeout: "{{ .Values.scheduler_timeout}}"
     service_type: "{{ .Values.service_type}}"
-    sync_replication: {{ .Values.sync_replication}}
+    sync_replication: "{{ .Values.sync_replication}}"
     backrest_storage: "{{ .Values.backrest_storage}}"
     backup_storage: "{{ .Values.backup_storage}}"
     primary_storage: "{{ .Values.primary_storage}}"
diff --git a/installers/helm/postgres-operator/values.yaml b/installers/helm/postgres-operator/values.yaml
@@ -23,7 +23,7 @@ serviceAccount:
 # More info for these options can be found in the docs
 # https://crunchydata.github.io/postgres-operator/latest/installation/configuration/
 # =====================
-archive_mode: true
+archive_mode: "true"
 archive_timeout: "60"
 backrest_aws_s3_bucket: ""
 backrest_aws_s3_endpoint: ""
@@ -33,13 +33,13 @@ backrest_aws_s3_secret: ""
 backrest_aws_s3_uri_style: ""
 backrest_aws_s3_verify_tls: true
 backrest_port: "2022"
-badger: false
+badger: "false"
 ccp_image_prefix: "registry.developers.crunchydata.com/crunchydata"
 ccp_image_pull_secret: ""
 ccp_image_pull_secret_manifest: ""
 ccp_image_tag: "centos7-12.3-4.4.0-rc.1"
-create_rbac: true
-crunchy_debug: false
+create_rbac: "true"
+crunchy_debug: "false"
 db_name: ""
 db_password_age_days: "0"
 db_password_length: "24"
@@ -49,30 +49,30 @@ db_user: "testuser"
 default_instance_memory: "128Mi"
 default_pgbackrest_memory: "48Mi"
 default_pgbouncer_memory: "24Mi"
-delete_metrics_namespace: false
-delete_operator_namespace: false
-delete_watched_namespaces: false
-disable_auto_failover: false
-disable_fsgroup: false
-reconcile_rbac: true
+delete_metrics_namespace: "false"
+delete_operator_namespace: "false"
+delete_watched_namespaces: "false"
+disable_auto_failover: "false"
+disable_fsgroup: "false"
+reconcile_rbac: "true"
 exporterport: "9187"
-metrics: false
+metrics: "false"
 namespace: "pgo"
 namespace_mode: "dynamic"
 pgbadgerport: "10000"
-pgo_add_os_ca_store: false
+pgo_add_os_ca_store: "false"
 pgo_admin_password: "examplepassword"
 pgo_admin_perms: "*"
 pgo_admin_role_name: "pgoadmin"
 pgo_admin_username: "admin"
 pgo_apiserver_port: "8443"
 pgo_apiserver_url: "https://postgres-operator"
 pgo_client_cert_secret: "pgo.tls"
-pgo_client_container_install: false
+pgo_client_container_install: "false"
 pgo_client_version: "4.4.0-rc.1"
-pgo_cluster_admin: false
-pgo_disable_eventing: false
-pgo_disable_tls: false
+pgo_cluster_admin: "false"
+pgo_disable_eventing: "false"
+pgo_disable_tls: "false"
 pgo_image_prefix: "registry.developers.crunchydata.com/crunchydata"
 pgo_image_pull_secret: ""
 pgo_image_pull_secret_manifest: ""
@@ -81,13 +81,13 @@ pgo_installation_name: "devtest"
 pgo_noauth_routes: ""
 pgo_operator_namespace: "pgo"
 pgo_tls_ca_store: ""
-pgo_tls_no_verify: false
+pgo_tls_no_verify: "false"
 pod_anti_affinity: "preferred"
 pod_anti_affinity_pgbackrest: ""
 pod_anti_affinity_pgbouncer: ""
 scheduler_timeout: "3600"
 service_type: "ClusterIP"
-sync_replication: false
+sync_replication: "false"
 backrest_storage: "hostpathstorage"
 backup_storage: "hostpathstorage"
 primary_storage: "hostpathstorage"
@@ -136,4 +136,4 @@ storage9_name: "rook"
 storage9_access_mode: "ReadWriteOnce"
 storage9_size: "1Gi"
 storage9_type: "dynamic"
-storage9_class: "rook-ceph-block"    
+storage9_class: "rook-ceph-block"
diff --git a/installers/kubectl/postgres-operator-ocp311.yml b/installers/kubectl/postgres-operator-ocp311.yml
diff --git a/installers/kubectl/postgres-operator.yml b/installers/kubectl/postgres-operator.yml
