Soften the display amounts for "pgo df"

While we will continue to "divide by 1024", if the remaining
value is still over 1000, we will divide by 1024 again. It feels
more natural to read "1GiB" instead of "1024MiB".

Author: Jonathan S. Katz

docs/content/releases/4.5.0.md

@@ -135,6 +135,7 @@ To remove an annotation, one follows the format:
   - Any customizations for the cluster (e.g. custom PostgreSQL configuration) will be available.
   - This also fixes several bugs that were reported with the `pgo restore` functionality, some of which are captured further down in these release notes.
 - The [Downward API](https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/) is now available to PostgreSQL instances.
+- The `pgo df` command will round values over 1000 up to the next unit type, e.g. `1GiB` instead of `1024MiB`.
 
 ## Fixes
 

pgo/cmd/common.go

@@ -107,12 +107,11 @@ func getSizeAndUnit(size int64) (float64, unitType) {
 	normalizedSize := float64(size)
 
 	// We keep dividing by "unitSize" which is 1024. Once it is less than the unit
-	// size, that is the normalized unit we will use.
-	// The astute observer will note that "du" returns in units of 1024, but we
-	// want to attempt to keep things in the 3-digit area
+	// size, or really, once it's less than "1000" of that unit size, that is
+	// normalized unit we will use.
 	//
 	// of course, eventually this will get too big...so bail after yotta bytes
-	for unit = unitB; normalizedSize > unitSize && unit < unitYB; unit++ {
+	for unit = unitB; normalizedSize > 1000 && unit < unitYB; unit++ {
 		normalizedSize /= unitSize
 	}