Cleanup Bootstrap Secret When rmdata Runs

When a rmdata Job is run to delete a PG cluster, it will now attempt to
remove the pgBackRest bootstrap Secret (if present).  This ensures that
the bootstrap Secret is properly removed after a failed bootstrap
attempt, i.e. when the cluster is deleted and then created again to
reattempt creation of the PG cluster.

Issue: [ch12505]

Author: andrewlecuyer

cmd/pgo-rmdata/process.go

@@ -159,6 +159,8 @@ func Delete(request Request) {
 		removeBackupSecrets(request)
 		removeAllBackupPVCs(request)
 	}
+	// remove the bootstrap secret if present
+	removeBootstrapSecret(request)
 }
 
 // removeBackRestRepo removes the pgBackRest repo that is associated with the
@@ -219,6 +221,20 @@ func removeBackupSecrets(request Request) {
 	}
 }
 
+// removeBootstrapSecret removes the pgbackrest bootstrap secret.  Specifically, if a
+// cluster is being deleted after a failed bootstrap attempt using a "pgDataSource", a
+// "bootstrap" pgBackRest secret might still be present.  Therefore, attempt to remove
+// it here, but ignore any "does not exist" errors since it typically will not be present.
+func removeBootstrapSecret(request Request) {
+	ctx := context.TODO()
+	if err := request.Clientset.CoreV1().Secrets(request.Namespace).Delete(ctx,
+		fmt.Sprintf(util.BootstrapConfigPrefix, request.ClusterName,
+			config.LABEL_BACKREST_REPO_SECRET),
+		metav1.DeleteOptions{}); err != nil && !kerror.IsNotFound(err) {
+		log.Error(err)
+	}
+}
+
 // removeClusterConfigmaps deletes the configmaps that are created for each
 // cluster. The first two are created by Patroni when it initializes a new cluster:
 // <cluster-name>-leader (stores data pertinent to the leader election process)