removes unused Clusteridentifier field

The Clusteridentifier field was added for a future event client
requirement to uniquely identify the underlying cluster.
The current implementation does not return Clusteridentifier
content with the message as nothing is populating the pg-cluster-id
is not being set.

Any direct usage of the field in dependent code will fail compilation.

Author: wilybrace

apiserver/clusterservice/clusterimpl.go

@@ -406,7 +406,6 @@ func TestCluster(name, selector, ns, pgouser string, allFlag bool) msgs.ClusterT
 				EventType: events.EventTestCluster,
 			},
 			Clustername:       c.Name,
-			Clusteridentifier: c.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		}
 
 		err = events.Publish(f)

apiserver/labelservice/labelimpl.go

@@ -140,7 +140,6 @@ func addLabels(items []crv1.Pgcluster, DryRun bool, LabelCmdLabel string, newLab
 					EventType: events.EventCreateLabel,
 				},
 				Clustername:       items[i].Spec.Name,
-				Clusteridentifier: items[i].ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 				Label:             LabelCmdLabel,
 			}
 

apiserver/loadservice/loadimpl.go

@@ -196,7 +196,6 @@ func Load(request *msgs.LoadRequest, ns, pgouser string) msgs.LoadResponse {
 				EventType: events.EventLoad,
 			},
 			Clustername:       c.Name,
-			Clusteridentifier: c.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 			Loadconfig:        LoadCfg.TableToLoad,
 		}
 

apiserver/policyservice/policyimpl.go

@@ -275,7 +275,6 @@ func ApplyPolicy(request *msgs.ApplyPolicyRequest, ns, pgouser string) msgs.Appl
 				EventType: events.EventApplyPolicy,
 			},
 			Clustername:       d.ObjectMeta.Labels[config.LABEL_PG_CLUSTER],
-			Clusteridentifier: d.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 			Policyname:        request.Name,
 		}
 

apiserver/reloadservice/reloadimpl.go

@@ -119,7 +119,6 @@ func Reload(request *msgs.ReloadRequest, ns, username string) msgs.ReloadRespons
 				EventType: events.EventReloadCluster,
 			},
 			Clustername:       cluster.Spec.Name,
-			Clusteridentifier: cluster.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		}
 
 		err = events.Publish(f)

apiserver/userservice/userimpl.go

@@ -220,7 +220,6 @@ func UpdateUser(request *msgs.UpdateUserRequest, pgouser string) msgs.UpdateUser
 						EventType: events.EventChangePasswordUser,
 					},
 					Clustername:       cluster.Spec.Name,
-					Clusteridentifier: cluster.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 					PostgresUsername:  request.Username,
 					PostgresPassword:  request.Password,
 				}
@@ -756,7 +755,6 @@ func CreateUser(request *msgs.CreateUserRequest, pgouser string) msgs.CreateUser
 			PostgresUsername:  request.Username,
 			PostgresPassword:  newPassword,
 			Managed:           request.ManagedUser,
-			Clusteridentifier: c.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		}
 
 		err = events.Publish(f)
@@ -897,7 +895,6 @@ func DeleteUser(request *msgs.DeleteUserRequest, pgouser string) msgs.DeleteUser
 			Clustername:       clusterName,
 			PostgresUsername:  request.Username,
 			Managed:           managed,
-			Clusteridentifier: cluster.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		}
 
 		err = events.Publish(f)

controller/jobcontroller.go

@@ -310,7 +310,6 @@ func (c *JobController) onUpdate(oldObj, newObj interface{}) {
 				EventType: events.EventBenchmarkCompleted,
 			},
 			Clustername:       labels[config.LABEL_PG_CLUSTER],
-			Clusteridentifier: labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		}
 
 		err = events.Publish(f)
@@ -472,7 +471,6 @@ func publishBackupComplete(clusterName, clusterIdentifier, username, backuptype,
 			EventType: events.EventCreateBackupCompleted,
 		},
 		Clustername:       clusterName,
-		Clusteridentifier: clusterIdentifier,
 		BackupType:        backuptype,
 		Path:              path,
 	}
@@ -496,7 +494,6 @@ func publishRestoreComplete(clusterName, identifier, username, namespace string)
 			EventType: events.EventRestoreClusterCompleted,
 		},
 		Clustername:       clusterName,
-		Clusteridentifier: identifier,
 	}
 
 	err := events.Publish(f)
@@ -519,7 +516,6 @@ func publishDeleteClusterComplete(clusterName, identifier, username, namespace s
 			EventType: events.EventDeleteClusterCompleted,
 		},
 		Clustername:       clusterName,
-		Clusteridentifier: identifier,
 	}
 
 	err := events.Publish(f)

controller/podcontroller.go

@@ -409,7 +409,6 @@ func publishClusterComplete(clusterName, namespace string, cluster *crv1.Pgclust
 			EventType: events.EventCreateClusterCompleted,
 		},
 		Clustername:       clusterName,
-		Clusteridentifier: cluster.ObjectMeta.Labels[config.LABEL_PG_CLUSTER_IDENTIFIER],
 		WorkflowID:        cluster.Spec.UserLabels[config.LABEL_WORKFLOW_ID],
 	}
 
@@ -473,7 +472,6 @@ func publishPrimaryNotReady(clusterName, identifier, username, namespace string)
 			EventType: events.EventPrimaryNotReady,
 		},
 		Clustername:       clusterName,
-		Clusteridentifier: identifier,
 	}
 
 	err := events.Publish(f)