Fix --target Option Detection for Restores

A regex is now used to determine whether or not a "--target" flag
already exists in the options provided for a pgBackRest restore.
This avoids conflicts with other options containing the string "target"
(e.g. "--target-action"), therefore ensuring the PITR target is
properly injected into the pgBackRest options as needed.

Issue: [ch9162]

Author: andrewlecuyer

internal/operator/backrest/restore.go

@@ -18,6 +18,7 @@ package backrest
 import (
 	"errors"
 	"fmt"
+	"regexp"
 	"strconv"
 	"strings"
 	"time"
@@ -35,6 +36,10 @@ import (
 	"k8s.io/apimachinery/pkg/util/wait"
 )
 
+// restoreTargetRegex defines a regex to detect if a restore target has been specified
+// for pgBackRest using the '--target' option
+var restoreTargetRegex = regexp.MustCompile("--target(=| +)")
+
 type BackrestRestoreJobTemplateFields struct {
 	JobName                string
 	ClusterName            string
@@ -67,7 +72,7 @@ func UpdatePGClusterSpecForRestore(clientset kubeapi.Interface, cluster *crv1.Pg
 
 	// set the proper target for the restore job
 	pitrTarget := task.Spec.Parameters[config.LABEL_BACKREST_PITR_TARGET]
-	if pitrTarget != "" && !strings.Contains(restoreOpts, "--target") {
+	if pitrTarget != "" && !restoreTargetRegex.MatchString(restoreOpts) {
 		restoreOpts = fmt.Sprintf("%s --target=%s", restoreOpts, strconv.Quote(pitrTarget))
 	}