PR feedback

benjaminjb · web-flow · commit 83d299e3210c · 2025-08-25T15:34:29.000-05:00
diff --git a/internal/pgbouncer/reconcile.go b/internal/pgbouncer/reconcile.go
@@ -150,8 +150,13 @@ func Pod(
 	}
 
 	mkdirCommand := ""
-	if logfile != "" && filepath.Dir(logfile) != "/tmp" {
-		mkdirCommand = shell.MakeDirectories("/tmp", filepath.Dir(logfile)) + "; "
+	// filepath.Dir will return an "" when given an ""
+	logPath := filepath.Dir(logfile)
+	// If the logpath is `/tmp`, we don't need to worry about creating/chmoding it.
+	// Otherwise, use `MakeDirectories` to create/chmod that specific directory,
+	// without worrying about parent directories.
+	if logfile != "" && logPath != "/tmp" {
+		mkdirCommand = shell.MakeDirectories(logPath, logPath) + "; "
 	}
 
 	container := corev1.Container{

Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,13 @@ func Pod(`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`mkdirCommand := ""`
`153`		`- if logfile != "" && filepath.Dir(logfile) != "/tmp" {`
`154`		`- mkdirCommand = shell.MakeDirectories("/tmp", filepath.Dir(logfile)) + "; "`
	`153`	`+ // filepath.Dir will return an "" when given an ""`
	`154`	`+ logPath := filepath.Dir(logfile)`
	`155`	+ // If the logpath is `/tmp`, we don't need to worry about creating/chmoding it.
	`156`	+ // Otherwise, use `MakeDirectories` to create/chmod that specific directory,
	`157`	`+ // without worrying about parent directories.`
	`158`	`+ if logfile != "" && logPath != "/tmp" {`
	`159`	`+ mkdirCommand = shell.MakeDirectories(logPath, logPath) + "; "`
`155`	`160`	`}`
`156`	`161`
`157`	`162`	`container := corev1.Container{`