Skip to content

Commit 9e0ff6d

Browse files
author
Jeff McCormick
committed
change the delete sequence and delete actions to avoid waiting
1 parent a9bd6d3 commit 9e0ff6d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

operator/cluster/cluster.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ func deleteCluster(clientset *kubernetes.Clientset, client *rest.RESTClient, cl
203203
log.Error("invalid STRATEGY requested for cluster creation" + cl.Spec.STRATEGY)
204204
return
205205
}
206-
strategy.DeleteCluster(clientset, client, cl, namespace)
207206
util.DeleteDatabaseSecrets(clientset, cl.Spec.Name, namespace)
207+
strategy.DeleteCluster(clientset, client, cl, namespace)
208208
err := client.Delete().
209209
Resource("pgupgrades").
210210
Namespace(namespace).

operator/cluster/cluster_strategy_1.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,11 +289,13 @@ func shutdownCluster(clientset *kubernetes.Clientset, client *rest.RESTClient, c
289289
}
290290

291291
//wait for the replica deployment to delete
292-
err = util.WaitUntilDeploymentIsDeleted(clientset, replicaName, time.Minute, namespace)
292+
/**
293+
err = util.WaitUntilDeploymentIsDeleted(clientset, replicaName, 2 * time.Minute, namespace)
293294
if err != nil {
294295
log.Error("error waiting for replica Deployment deletion " + err.Error())
295296
}
296297
log.Info("deleted replica Deployment " + replicaName + " in namespace " + namespace)
298+
*/
297299

298300
//delete the master deployment
299301
err = clientset.Deployments(namespace).Delete(cl.Spec.Name, &v1.DeleteOptions{})
@@ -302,7 +304,8 @@ func shutdownCluster(clientset *kubernetes.Clientset, client *rest.RESTClient, c
302304
}
303305

304306
//wait for the master deployment to delete
305-
err = util.WaitUntilDeploymentIsDeleted(clientset, cl.Spec.Name, time.Minute, namespace)
307+
/**
308+
err = util.WaitUntilDeploymentIsDeleted(clientset, cl.Spec.Name, 2 * time.Minute, namespace)
306309
if err != nil {
307310
log.Error("error waiting for master Deployment deletion " + err.Error())
308311
}
@@ -327,6 +330,7 @@ func shutdownCluster(clientset *kubernetes.Clientset, client *rest.RESTClient, c
327330
log.Info("deleted cluster replicaset " + r.Name + " in namespace " + namespace)
328331
}
329332
}
333+
*/
330334

331335
return err
332336

0 commit comments

Comments
 (0)