Updates validation logic on pgBackRest backup options

Currently validation is run on backup options passed in with the --backup-opts
flag to reject unknown or blacklisted flags. This commit updates the validation
to only reject blacklisted flags and allow unknown flags to be passed into the
operator. This will make new pgBackRest features and flags easier to support by
relying on the builtin pgBackRest validation. Now new pgBackrest flags can be
used without updating the list of known flags.

The handleCustomParseErrors function now will take the unknown flag error and
check if the flag is blacklisted. If not, the error is ignored and nil is
returned.

A second level check is added to validate the parsedBackupOpts. Now the return
from handleCustomParseErrors is checked rather than immediately returned.

Author: jmckulk

apiserver/backupoptions/backupoptionsutil.go

@@ -98,7 +98,10 @@ func convertBackupOptsToStruct(backupOpts string, request interface{}) (backupOp
 
 	err = commandLine.Parse(parsedBackupOpts)
 	if err != nil {
-		return nil, nil, handleCustomParseErrors(err, usage, optsStruct)
+		err = handleCustomParseErrors(err, usage, optsStruct)
+		if err != nil {
+			return nil, nil, err
+		}
 	}
 
 	setFlagFieldNames := obtainSetFlagFieldNames(commandLine, structType)
@@ -183,6 +186,9 @@ func isValidValue(vals []string, val string) bool {
 	return isValid
 }
 
+// this function checks unknown options from the backup-opts flag to validate that they are not blacklisted
+// if the option is in the blacklist and error is returned, otherwise the flag is unkown to the operator
+// and can be passed to pgBackRest for validation.
 func handleCustomParseErrors(err error, usage *bytes.Buffer, optsStruct backupOptions) error {
 	blacklistFlags, blacklistFlagsShort := optsStruct.getBlacklistFlags()
 	if err.Error() == "pflag: help requested" {
@@ -205,7 +211,7 @@ func handleCustomParseErrors(err error, usage *bytes.Buffer, optsStruct backupOp
 			}
 		}
 	}
-	return err
+	return nil
 }
 
 func obtainSetFlagFieldNames(commandLine *pflag.FlagSet, structType reflect.Type) []string {