FIXUP: dots-only filenames

Author: cbandy

internal/shell/paths.go

@@ -22,9 +22,10 @@ import (
 // See:
 //   - https://pubs.opengroup.org/onlinepubs/9799919799/utilities/basename.html
 func CleanFileName(path string) string {
-	if i := strings.LastIndexByte(path, '/'); i < 0 {
-		return path
-	} else if path = path[i+1:]; path != "." && path != ".." {
+	if i := strings.LastIndexByte(path, '/'); i >= 0 {
+		path = path[i+1:]
+	}
+	if path != "." && path != ".." {
 		return path
 	}
 	return ""

internal/shell/paths_test.go

@@ -25,12 +25,17 @@ func TestCleanFileName(t *testing.T) {
 	})
 
 	t.Run("Dots", func(t *testing.T) {
+		assert.Equal(t, CleanFileName("."), "")
+		assert.Equal(t, CleanFileName(".."), "")
+		assert.Equal(t, CleanFileName("..."), "...")
+		assert.Equal(t, CleanFileName("././/.././../."), "")
 		assert.Equal(t, CleanFileName("././/.././../.."), "")
 		assert.Equal(t, CleanFileName("././/.././../../x.j"), "x.j")
 	})
 
 	t.Run("Directories", func(t *testing.T) {
 		assert.Equal(t, CleanFileName("/"), "")
+		assert.Equal(t, CleanFileName("//"), "")
 		assert.Equal(t, CleanFileName("asdf/"), "")
 		assert.Equal(t, CleanFileName("asdf//12.3"), "12.3")
 		assert.Equal(t, CleanFileName("//////"), "")