Allow for empty --service-type on pgo create pgbouncer

jkatz · web-flow · commit d43dbac3c55e · 2021-01-05T15:11:52.000-05:00
This was an oversight in the logic for allowing a default pgBouncer
Service Type to be set.

Issue: [ch10065]
diff --git a/internal/apiserver/pgbouncerservice/pgbouncerimpl.go b/internal/apiserver/pgbouncerservice/pgbouncerimpl.go
@@ -116,7 +116,7 @@ func CreatePgbouncer(request *msgs.CreatePgbouncerRequest, ns, pgouser string) m
 			resp.Status.Msg = fmt.Sprintf("invalid service type %q", request.ServiceType)
 			return resp
 		case v1.ServiceTypeClusterIP, v1.ServiceTypeNodePort,
-			v1.ServiceTypeLoadBalancer, v1.ServiceTypeExternalName:
+			v1.ServiceTypeLoadBalancer, v1.ServiceTypeExternalName, "":
 			cluster.Spec.PgBouncer.ServiceType = request.ServiceType
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ func CreatePgbouncer(request *msgs.CreatePgbouncerRequest, ns, pgouser string) m`
`116`	`116`	`resp.Status.Msg = fmt.Sprintf("invalid service type %q", request.ServiceType)`
`117`	`117`	`return resp`
`118`	`118`	`case v1.ServiceTypeClusterIP, v1.ServiceTypeNodePort,`
`119`		`- v1.ServiceTypeLoadBalancer, v1.ServiceTypeExternalName:`
	`119`	`+ v1.ServiceTypeLoadBalancer, v1.ServiceTypeExternalName, "":`
`120`	`120`	`cluster.Spec.PgBouncer.ServiceType = request.ServiceType`
`121`	`121`	`}`
`122`	`122`