Fix delete checked children from unchecked parent

Author: Crustack

app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/ListItemCollectionExtensions.kt

@@ -269,10 +269,13 @@ fun SortedList<ListItem>.deleteCheckedItems() {
 
 fun MutableList<ListItem>.deleteCheckedItems(): Set<Int> {
     return mapIndexed { index, listItem -> Pair(index, listItem) }
-        .filter { it.second.checked }
-        .sortedBy { it.second.isChild }
-        .onEach { remove(it.second) }
-        .map { it.first }
+        .filter { (_, item) -> item.checked }
+        .sortedBy { (_, item) -> item.isChild }
+        .onEach { (_, item) ->
+            removeFromParent(item)
+            remove(item)
+        }
+        .map { (index, _) -> index }
         .toSet()
 }
 

app/src/test/kotlin/com/philkes/notallyx/recyclerview/listmanager/ListManagerAddDeleteTest.kt

@@ -152,6 +152,21 @@ class ListManagerAddDeleteTest : ListManagerTestBase() {
         items.assertOrder("B", "E", "F")
     }
 
+    @Test
+    fun `delete unchecked child from otherwise unchecked parent`() {
+        setSorting(ListItemSort.NO_AUTO_SORT)
+        listManager.changeIsChild(2, true)
+        listManager.changeIsChild(3, true)
+        listManager.changeChecked(2, true)
+
+        listManager.deleteCheckedItems()
+
+        items.assertOrder("A", "B", "D", "E", "F")
+        "B".assertChildren("D")
+        "B".assertIsNotChecked()
+        "D".assertIsNotChecked()
+    }
+
     @Test
     fun `delete checked items with auto-sort enabled`() {
         setSorting(ListItemSort.AUTO_SORT_BY_CHECKED)