Merge pull request #147 from f1x3d/fix-static-analysis-issues

Fix static analysis issues

Author: CrustyJew

RedditSharp/Things/Comment.cs

@@ -165,7 +165,7 @@ private void ParseComments(JToken data, Thing sender)
         public Thing Parent { get; internal set; }
 
 		/// <inheritdoc/>
-		public override string Shortlink => Permalink;
+		public override string Shortlink => Permalink.ToString();
 
         /// <summary>
         /// Reply to this comment.

RedditSharp/Things/LiveUpdateEvent.cs

@@ -311,9 +311,10 @@ public async Task<bool> RemoveContributorAsync(RedditUser user)
         /// Remove a contributor from the live thread.
         /// </summary>
         /// <param name="userName">reddit username.</param>
-        public Task<bool> RemoveContributorAsync(string userName)
+        public async Task<bool> RemoveContributorAsync(string userName)
         {
-            return RemoveContributorAsync(userName);
+            var redditUser = await RedditUser.GetUserAsync(WebAgent, userName);
+            return await RemoveContributorAsync(redditUser).ConfigureAwait(false);
         }
 
         /// <summary>

RedditSharp/WebAgent.cs

@@ -109,6 +109,7 @@ public virtual async Task<JToken> ExecuteRequestAsync(Func<HttpRequestMessage> r
               await RateLimiter.CheckRateLimitAsync(IsOAuth).ConfigureAwait(false);
               response = await _httpClient.SendAsync(request()).ConfigureAwait(false);
               await RateLimiter.ReadHeadersAsync(response);
+              ++tries;
             } while( 
             //only retry if 500 or 503
                 (response.StatusCode == System.Net.HttpStatusCode.InternalServerError || 
@@ -229,7 +230,7 @@ public virtual void WritePostBody(HttpRequestMessage request, object data, param
             }
             for (int i = 0; i < additionalFields.Length; i += 2)
             {
-                var entry = Convert.ToString(additionalFields[i + 1]) ?? string.Empty;
+                var entry = Convert.ToString(additionalFields[i + 1]);
                 content.Add(new KeyValuePair<string, string>(additionalFields[i], entry));
             }
             //new FormUrlEncodedContent has a limit on length which can cause issues;