Change inheritance so that ModeratorUser, BannedUser, Contributor all inherit from RelUser.

Author: jkrejcha

RedditSharp/Moderator Actions/ModeratorUser.cs

@@ -1,45 +1,23 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
+using RedditSharp.Things.User;
 
 namespace RedditSharp
 {
     /// <summary>
     /// Represents a moderator.
     /// </summary>
-    public class ModeratorUser
+    public class ModeratorUser : RelUser
     {
-        /// <summary>
-        /// Create ModeratorUser from given JSON
-        /// </summary>
-        /// <param name="json"></param>
-        public ModeratorUser(JToken json)
-        {
-            Helpers.PopulateObject(json, this);
-        }
+		public ModeratorUser(IWebAgent agent, JToken json) : base(agent, json)
+		{
+		}
 
-        /// <summary>
-        /// Moderator username.
-        /// </summary>
-        [JsonProperty("name")]
-        public string Name { get; private set; }
-
-        /// <summary>
-        /// base36 Id of the moderator.
-        /// </summary>
-        [JsonProperty("id")]
-        public string Id { get; private set; }
-
-        /// <summary>
-        /// Permissions the moderator has in the subreddit.
-        /// </summary>
-        [JsonProperty("mod_permissions")]
+		/// <summary>
+		/// Permissions the moderator has in the subreddit.
+		/// </summary>
+		[JsonProperty("mod_permissions")]
         [JsonConverter(typeof (ModeratorPermissionConverter))]
         public ModeratorPermission Permissions { get; private set; }
-
-        /// <inheritdoc/>
-        public override string ToString()
-        {
-            return Name;
-        }
     }
 }

RedditSharp/Things/BannedUser.cs

@@ -1,51 +1,29 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
-using RedditSharp.Extensions;
+using RedditSharp.Things.User;
 using System;
 
 namespace RedditSharp.Things
 {
     /// <summary>
     /// A user that is banned in a subreddit.
     /// </summary>
-    public class BannedUser : RedditUser
+    public class BannedUser : RelUser
     {
         /// <inheritdoc />
         public BannedUser(IWebAgent agent, JToken json) : base(agent, json) {
-            var data = json["name"] == null ? json["data"] : json;
-            base.Name = data["name"].ValueOrDefault<string>();
-            var id = data["id"].ValueOrDefault<string>();
-            if (id.Contains("_"))
-            {
-                base.Kind = "t2";
-                base.Id = id.Split('_')[1];
-                base.FullName = id;
-            }
         }
 
         /// <summary>
         /// Date the user was banned.
         /// </summary>
-        [JsonProperty("date")]
-        [JsonConverter(typeof(UnixTimestampConverter))]
-        public DateTime? BanDate { get; private set; }
+        [Obsolete("User RelUser.Date")]
+        public DateTime? BanDate { get => DateUTC; private set => DateUTC = value; }
 
         /// <summary>
         /// Ban note.
         /// </summary>
         [JsonProperty("note")]
         public string Note { get; private set; }
-
-        /// <summary>
-        /// This will always return 0 for BannedUsers
-        /// </summary>
-        [JsonIgnore]
-        public new int CommentKarma => 0;
-
-        /// <summary>
-        /// This will always return 0 for BannedUsers
-        /// </summary>
-        [JsonIgnore]
-        public new int LinkKarma => 0;
     }
 }

RedditSharp/Things/Contributor.cs

@@ -1,50 +1,23 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
-using RedditSharp.Extensions;
+using RedditSharp.Things.User;
 using System;
 
 namespace RedditSharp.Things
 {
     /// <summary>
     /// A contributor to a subreddit.
     /// </summary>
-    public class Contributor : RedditUser
+    public class Contributor : RelUser
     {
         /// <inheritdoc />
         public Contributor(IWebAgent agent, JToken json) : base(agent, json) {
-            var data = json["name"] == null ? json["data"] : json;
-            base.Name = data["name"].ValueOrDefault<string>();
-            var id = data["id"].ValueOrDefault<string>();
-            if (id.Contains("_"))
-            {
-                base.Id = id.Split('_')[1];
-                base.FullName = id;
-            }
         }
 
-        /// <summary>
-        /// Contributor name.
-        /// </summary>
-        [JsonProperty("name")]
-        public new string Name { get; private set; }
-
-        /// <summary>
-        /// Date contributor was added.
-        /// </summary>
-        [JsonProperty("date")]
-        [JsonConverter(typeof(UnixTimestampConverter))]
-        public DateTime DateAdded { get; private set; }
-
-        /// <summary>
-        /// This will always return 0 for Contributors
-        /// </summary>
-        [JsonIgnore]
-        public new int CommentKarma => 0;
-
-        /// <summary>
-        /// This will always return 0 for Contributors
-        /// </summary>
-        [JsonIgnore]
-        public new int LinkKarma => 0;
-    }
+		/// <summary>
+		/// Date contributor was added.
+		/// </summary>
+		[Obsolete("User RelUser.Date")]
+		public DateTime? DateAdded { get => DateUTC; private set => DateUTC = value; }
+	}
 }

RedditSharp/Things/Subreddit.cs

@@ -950,7 +950,7 @@ public static async Task<IEnumerable<ModeratorUser>> GetModeratorsAsync(IWebAgen
             var mods = data["children"].ToArray();
             var result = new ModeratorUser[mods.Length];
             for(var i = 0; i < mods.Length; i++) {
-                var mod = new ModeratorUser(mods[i]);
+                var mod = new ModeratorUser(agent, mods[i]);
                 result[i] = mod;
             }
             return result;

RedditSharp/Things/User/PartialUser.cs

@@ -1,5 +1,6 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
+using RedditSharp.Extensions;
 using System;
 using System.Threading.Tasks;
 
@@ -13,6 +14,14 @@ public class PartialUser : CreatedThing
 		/// <inheritdoc />
 		public PartialUser(IWebAgent agent, JToken json) : base(agent, json)
 		{
+			var data = json["name"] == null ? json["data"] : json;
+			Name = data["name"].ValueOrDefault<string>();
+			var id = data["id"].ValueOrDefault<string>();
+			if (id.Contains("_"))
+			{
+				base.Id = id.Split('_')[1];
+				base.FullName = id;
+			}
 		}
 		#region Properties
 		private string OverviewUrl => $"/user/{Name}.json";