JSON value access error in submission and editing methods

Multiple methods related to submission or editing had similar errors when attempting to access a returned JSON object.

Many tried to get a root node named "json" from a json object. No such node existed (or was already parsed out in the WebAgent's ExecuteRequestAsync method) and so an exception was thrown.

Many incorrectly parsed any returned ratelimit error (the "You are doing that too much." error).

Related to the ratelimit error, a few of the methods incorrectly checked if the json object returned any errors.

Author: cwhitman

RedditSharp/Reddit.cs

@@ -229,10 +229,10 @@ public async Task<LiveUpdateEvent> CreateLiveEventAsync(string title, string des
                 nsfw = nsfw
             }).ConfigureAwait(false);
 
-            if (json["json"]["errors"].Any())
-                throw new Exception(json["json"]["errors"][0][0].ToString());
+            if (json["errors"].Any())
+                throw new Exception(json["errors"][0][0].ToString());
 
-            var id = json["json"]["data"]["id"].ToString();
+            var id = json["data"]["id"].ToString();
 
             return await GetLiveEvent(new Uri(String.Format(GetLiveEventUrl, id))).ConfigureAwait(false);
         }

RedditSharp/Things/Comment.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Text.RegularExpressions;
 using System.Threading.Tasks;
 
 namespace RedditSharp.Things
@@ -176,16 +177,26 @@ public async Task<Comment> ReplyAsync(string message)
             // TODO actual error handling. This just hides the error and returns null
             //try
             //{
-                var json = await WebAgent.Post(CommentUrl, new
+            var json = await WebAgent.Post(CommentUrl, new
+            {
+                text = message,
+                thing_id = FullName,
+                api_type = "json"
+                //r = Subreddit
+            }).ConfigureAwait(false);
+            if (json["errors"].Any())
+            {
+                if (json["errors"][0].Any(x => x.ToString() == "RATELIMIT" || x.ToString() == "ratelimit"))
                 {
-                    text = message,
-                    thing_id = FullName,
-                    api_type = "json"
-                    //r = Subreddit
-                }).ConfigureAwait(false);
-                if (json["json"]["ratelimit"] != null)
-                    throw new RateLimitException(TimeSpan.FromSeconds(json["json"]["ratelimit"].ValueOrDefault<double>()));
-                return new Comment(WebAgent, json["json"]["data"]["things"][0], this);
+                    var timeToReset = TimeSpan.FromMinutes(Convert.ToDouble(Regex.Match(json["errors"][0].ElementAt(1).ToString(), @"\d+").Value));
+                    throw new RateLimitException(timeToReset);
+                }
+                else
+                {
+                    throw new Exception(json["errors"][0][0].ToString());
+                }
+            }
+            return new Comment(WebAgent, json["data"]["things"][0], this);
             //}
             //catch (HttpRequestException ex)
             //{
@@ -206,10 +217,10 @@ public async Task EditTextAsync(string newText)
                 text = newText,
                 thing_id = FullName
             }).ConfigureAwait(false);
-            if (!json["json"]["errors"].Any())
+            if (!json["errors"].Any())
                 Body = newText;
             else
-                throw new Exception($"Errors editing text {json["json"]["errors"][0][0].ToString()}");
+                throw new Exception($"Errors editing text {json["errors"][0][0].ToString()}");
         }
 
         /// <inheritdoc />

RedditSharp/Things/LiveUpdateEvent.cs

@@ -196,7 +196,7 @@ public async Task<bool> EditAsync(string title, string description, string resou
 
             var data = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
             JToken json = JToken.Parse(data);
-            if (!json["json"]["errors"].Any())
+            if (json["success"].Value<Boolean>())
             {
                 Title = title ?? "";
                 Description = description ?? "";

RedditSharp/Things/Post.cs

@@ -6,6 +6,7 @@
 using System.Linq;
 using System.Reactive.Linq;
 using System.Threading.Tasks;
+using System.Text.RegularExpressions;
 
 namespace RedditSharp.Things
 {
@@ -143,9 +144,20 @@ public async Task<Comment> CommentAsync(string message)
                 thing_id = FullName,
                 api_type = "json"
             }).ConfigureAwait(false);
-            if (json["json"]["ratelimit"] != null)
-                throw new RateLimitException(TimeSpan.FromSeconds(json["json"]["ratelimit"].ValueOrDefault<double>()));
-            return new Comment(WebAgent, json["json"]["data"]["things"][0], this);
+            if (json["errors"].Any())
+            {
+                if (json["errors"][0].Any(x => x.ToString() == "RATELIMIT" || x.ToString() == "ratelimit"))
+                {
+                    var timeToReset = TimeSpan.FromMinutes(Convert.ToDouble(Regex.Match(json["errors"][0].ElementAt(1).ToString(), @"\d+").Value));
+                    throw new RateLimitException(timeToReset);
+                }
+                else
+                {
+                    throw new Exception(json["errors"][0][0].ToString());
+                }
+            }
+
+            return new Comment(WebAgent, json["data"]["things"][0], this);
         }
 
         private async Task<JToken> SimpleActionToggleAsync(string endpoint, bool value, bool requiresModAction = false)
@@ -204,7 +216,7 @@ public async Task EditTextAsync(string newText)
                 text = newText,
                 thing_id = FullName
             }).ConfigureAwait(false);
-            if (json["json"].ToString().Contains("\"errors\": []"))
+            if (!json["errors"].Any())
                 SelfText = newText;
             else
                 throw new Exception("Error editing text.");
@@ -319,7 +331,7 @@ public IAsyncEnumerable<Comment> EnumerateCommentTreeAsync(int limitPerRequest =
         {
             return new CommentsEnumarable(WebAgent, this, limitPerRequest);
         }
-        #region Static Operations
+#region Static Operations
         /// <summary>
         /// Sets flair of given post by <paramref name="fullname"/>
         /// </summary>

RedditSharp/Things/Subreddit.cs

@@ -832,7 +832,7 @@ private async Task<Post> SubmitAsync(SubmitData data, ICaptchaSolver solver = nu
                     throw new CaptchaFailedException("Captcha required but not ICaptchaSolver provided");
                 }
 
-                data.Iden = json["json"]["captcha"].ToString();
+                data.Iden = json["captcha"].ToString();
                 CaptchaResponse captchaResponse = solver.HandleCaptcha(new Captcha(data.Iden));
 
                 // We throw exception due to this method being expected to return a valid Post object, but we cannot