Fix ban async, replace old ban methods with new

Author: absurdlyobfuscated

RedditSharp/Things/BannedUser.cs

@@ -1,6 +1,7 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 using System;
+using System.Threading.Tasks;
 
 namespace RedditSharp.Things
 {
@@ -26,6 +27,13 @@ public BannedUser Init(Reddit reddit, JToken json, IWebAgent webAgent)
             return this;
         }
 
+        public async Task<BannedUser> InitAsync(Reddit reddit, JToken json, IWebAgent webAgent)
+        {
+            CommonInit(json);
+            await JsonConvert.PopulateObjectAsync(json.ToString(), this, reddit.JsonSerializerSettings);
+            return this;
+        }
+
         private void CommonInit(JToken json)
         {
             base.Init(json);

RedditSharp/Things/Subreddit.cs

@@ -700,6 +700,7 @@ public void RemoveContributor(string id)
             var response = request.GetResponse();
             var result = WebAgent.GetResponseString(response.GetResponseStream());
         }
+
         public async Task RemoveContributorAsync(string id)
         {
             var request = WebAgent.CreatePost(LeaveModerationUrl);
@@ -714,42 +715,6 @@ public async Task RemoveContributorAsync(string id)
             var response = request.GetResponse();
             var result = WebAgent.GetResponseString(response.GetResponseStream());
         }
-        public void BanUser(string user, string reason)
-        {
-            var request = WebAgent.CreatePost(BanUserUrl);
-            WebAgent.WritePostBody(request.GetRequestStream(), new
-            {
-                api_type = "json",
-                uh = Reddit.User.Modhash,
-                r = Name,
-                type = "banned",
-                id = "#banned",
-                name = user,
-                note = reason,
-                action = "add",
-                container = FullName
-            });
-            var response = request.GetResponse();
-            var result = WebAgent.GetResponseString(response.GetResponseStream());
-        }
-        public async Task BanUserAsync(string user, string reason)
-        {
-            var request = WebAgent.CreatePost(BanUserUrl);
-            WebAgent.WritePostBody(await request.GetRequestStreamAsync(), new
-            {
-                api_type = "json",
-                uh = Reddit.User.Modhash,
-                r = Name,
-                type = "banned",
-                id = "#banned",
-                name = user,
-                note = reason,
-                action = "add",
-                container = FullName
-            });
-            var response = await request.GetResponseAsync();
-            var result = WebAgent.GetResponseString(response.GetResponseStream());
-        }
 
         /// <summary>
         /// Bans a user
@@ -799,6 +764,16 @@ public async Task BanUserAsync(string user, string reason, string note, int dura
             var result = WebAgent.GetResponseString(response.GetResponseStream());
         }
 
+        public void BanUser(string user, string note)
+        {
+            BanUser(user, "", note, 0, "");
+        }
+
+        public async Task BanUserAsync(string user, string note)
+        {
+            await BanUserAsync(user, "", note, 0, "");
+        }
+
         /// <summary>
         /// Unbans a user
         /// </summary>

RedditSharp/Things/Thing.cs

@@ -124,11 +124,11 @@ public static async Task<Thing> ParseAsync<T>(Reddit reddit, JToken json, IWebAg
                 }
                 else if (typeof(T) == typeof(Contributor))
                 {
-                    return new Contributor().Init(reddit, json, webAgent);
+                    return await new Contributor().InitAsync(reddit, json, webAgent);
                 }
                 else if (typeof(T) == typeof(BannedUser))
                 {
-                    return new BannedUser().Init(reddit, json, webAgent);
+                    return await new BannedUser().InitAsync(reddit, json, webAgent);
                 }
             }
             return result;