BM-226: Add Deposit and Withdrawal events (github#53)

Author: capossele

contracts/src/IProofMarket.sol

@@ -101,6 +101,10 @@ interface IProofMarket {
     event RequestFulfilled(uint192 indexed requestId, bytes journal, bytes seal);
     /// Event when prover stake is burned for failing to fulfill a request by the deadline.
     event LockinStakeBurned(uint192 indexed requestId, uint96 stake);
+    /// Event when a deposit is made to the proof market.
+    event Deposit(address indexed account, uint256 value);
+    /// Event when a withdrawal is made from the proof market.
+    event Withdrawal(address indexed account, uint256 value);
 
     /// Request is locked when it was not expected to be.
     error RequestIsLocked(uint192 requestId);

contracts/src/ProofMarket.sol

@@ -149,13 +149,15 @@ contract ProofMarket is IProofMarket, EIP712 {
     // Deposit Ether into the market.
     function deposit() public payable {
         accounts[msg.sender].balance += msg.value.toUint96();
+        emit Deposit(msg.sender, msg.value);
     }
 
     // Withdraw Ether from the market.
     function withdraw(uint256 value) public {
         accounts[msg.sender].balance -= value.toUint96();
         (bool sent,) = msg.sender.call{value: value}("");
         require(sent, "failed to send Ether");
+        emit Withdrawal(msg.sender, value);
     }
 
     // Get the current balance of an account.

contracts/test/ProofMarket.t.sol

@@ -194,6 +194,29 @@ contract ProofMarketTest is Test {
         return (fills, assessorSeal);
     }
 
+    function testDeposit() public {
+        vm.deal(PROVER_WALLET.addr, 1 ether);
+        // Deposit funds into the market
+        vm.expectEmit(true, true, false, true);
+        emit IProofMarket.Deposit(PROVER_WALLET.addr, 1 ether);
+        vm.prank(PROVER_WALLET.addr);
+        proofMarket.deposit{value: 1 ether}();
+    }
+
+    function testWithdraw() public {
+        // Deposit funds into the market
+        vm.deal(PROVER_WALLET.addr, 1 ether);
+        vm.prank(PROVER_WALLET.addr);
+        proofMarket.deposit{value: 1 ether}();
+
+        // Withdraw funds from the market
+        vm.expectEmit(true, true, false, true);
+        emit IProofMarket.Withdrawal(PROVER_WALLET.addr, 1 ether);
+        vm.prank(PROVER_WALLET.addr);
+        proofMarket.withdraw(1 ether);
+        checkProofMarketBalance();
+    }
+
     function testSubmitRequest() public {
         // Submit request
         Vm.Wallet memory client = createClient(1);

docs/src/market/rfc.md

@@ -160,6 +160,10 @@ interface IProofMarket {
     event RequestFulfilled(uint192 indexed requestId, bytes journal, bytes seal);
     /// Event when prover stake is burned for failing to fulfill a request by the deadline.
     event LockinStakeBurned(uint192 indexed requestId, uint96 stake);
+    /// Event when a deposit is made to the proof market.
+    event Deposit(address indexed account, uint256 value);
+    /// Event when a withdrawal is made from the proof market.
+    event Withdrawal(address indexed account, uint256 value);
 
     /// Request is locked when it was not expected to be.
     error RequestIsLocked(uint192 requestId);