BM-276: Move clientSignature args to calldata from memory (github#89)

Author: nategraf

contracts/src/IProofMarket.sol

@@ -141,14 +141,14 @@ interface IProofMarket {
     /// @notice Submit a request such that it is publicly available for provers to evaluate and bid on.
     ///         Any `msg.value` sent with the call will be added to the balance of `msg.sender`.
     /// @dev Submitting the transaction only broadcasting it, and is not a required step.
-    function submitRequest(ProvingRequest calldata request, bytes memory clientSignature) external payable;
+    function submitRequest(ProvingRequest calldata request, bytes calldata clientSignature) external payable;
 
     /// @notice Lock the proving request to the prover, giving them exclusive rights to be paid to
     /// fulfill this request, and also making them subject to slashing penalties if they fail to
     /// deliver. At this point, the price for fulfillment is also set, based on the reverse Dutch
     /// auction parameters and the block at which this transaction is processed.
     /// @dev This method should be called from the address of the prover.
-    function lockin(ProvingRequest calldata request, bytes memory clientSignature) external;
+    function lockin(ProvingRequest calldata request, bytes calldata clientSignature) external;
 
     /// @notice Lock the proving request to the prover, giving them exclusive rights to be paid to
     /// fulfill this request, and also making them subject to slashing penalties if they fail to
@@ -157,7 +157,7 @@ interface IProofMarket {
     /// @dev This method uses the provided signature to authenticate the prover.
     function lockinWithSig(
         ProvingRequest calldata request,
-        bytes memory clientSignature,
+        bytes calldata clientSignature,
         bytes calldata proverSignature
     ) external;
 

contracts/src/ProofMarket.sol

@@ -166,12 +166,12 @@ contract ProofMarket is IProofMarket, EIP712 {
         return uint256(accounts[addr].balance);
     }
 
-    function submitRequest(ProvingRequest calldata request, bytes memory clientSignature) external payable {
+    function submitRequest(ProvingRequest calldata request, bytes calldata clientSignature) external payable {
         accounts[msg.sender].balance += msg.value.toUint96();
         emit RequestSubmitted(request, clientSignature);
     }
 
-    function lockin(ProvingRequest calldata request, bytes memory clientSignature) external {
+    function lockin(ProvingRequest calldata request, bytes calldata clientSignature) external {
         (address client, uint32 idx) = (ProofMarketLib.requestFrom(request.id), ProofMarketLib.requestIndex(request.id));
 
         // Recover the prover address and require the client address to equal the address part of the ID.
@@ -183,7 +183,7 @@ contract ProofMarket is IProofMarket, EIP712 {
 
     function lockinWithSig(
         ProvingRequest calldata request,
-        bytes memory clientSignature,
+        bytes calldata clientSignature,
         bytes calldata proverSignature
     ) external {
         (address client, uint32 idx) = (ProofMarketLib.requestFrom(request.id), ProofMarketLib.requestIndex(request.id));