fix(pnl): skip invalid PnL; broadcast close only with real PnL

- Handle undefined/null/NaN in formatPnL by returning an empty string
- Show PnL in toasts only when a valid formatted value exists
- Default toast variant to success when PnL is missing/zero
- Stop broadcasting position_closed on immediate close; only send position_update
  and rely on ORDER_TRADE_UPDATE to broadcast position_closed with actual PnL

This prevents misleading "PnL: $NaN"/zero displays and avoids premature or duplicate
close notifications, improving accuracy and UX.

Author: CryptoGnome

src/hooks/useOrderNotifications.ts

@@ -27,7 +27,10 @@ export function useOrderNotifications(customWsUrl?: string) {
     }).format(qty);
   };
 
-  const formatPnL = (pnl: number) => {
+  const formatPnL = (pnl: number | undefined) => {
+    if (pnl === undefined || pnl === null || isNaN(pnl)) {
+      return '';
+    }
     const formatted = new Intl.NumberFormat('en-US', {
       style: 'currency',
       currency: 'USD',
@@ -76,7 +79,8 @@ export function useOrderNotifications(customWsUrl?: string) {
             case 'order_filled': {
               const { symbol, side, executedQty, price, orderType, pnl } = message.data;
               const priceStr = price ? ` at $${formatPrice(price)}` : '';
-              const pnlStr = pnl !== undefined && pnl !== 0 ? ` • PnL: ${formatPnL(pnl)}` : '';
+              const formattedPnl = formatPnL(pnl);
+              const pnlStr = formattedPnl ? ` • PnL: ${formattedPnl}` : '';
 
               if (orderType === 'STOP_MARKET' || orderType === 'STOP') {
                 toast.warning(
@@ -133,8 +137,9 @@ export function useOrderNotifications(customWsUrl?: string) {
 
             case 'position_closed': {
               const { symbol, side, quantity, pnl } = message.data;
-              const pnlStr = pnl !== undefined ? ` • PnL: ${formatPnL(pnl)}` : '';
-              const variant = pnl >= 0 ? 'success' : 'warning';
+              const formattedPnl = formatPnL(pnl);
+              const pnlStr = formattedPnl ? ` • PnL: ${formattedPnl}` : '';
+              const variant = pnl && pnl >= 0 ? 'success' : pnl && pnl < 0 ? 'warning' : 'success';
 
               toast[variant](
                 `💰 Position closed: ${symbol}`,

src/lib/bot/positionManager.ts

@@ -664,17 +664,10 @@ export class PositionManager extends EventEmitter implements PositionTracker {
             const previousAmt = parseFloat(previousPosition.positionAmt);
             console.log(`PositionManager: Position ${previousKey} fully closed`);
 
-            // Broadcast position closed event
+            // Don't broadcast position_closed here - it will be broadcast with actual PnL in ORDER_TRADE_UPDATE
+            // Only broadcast position_update for UI state updates
             if (this.statusBroadcaster) {
-              this.statusBroadcaster.broadcastPositionClosed({
-                symbol: symbol,
-                side: previousAmt > 0 ? 'LONG' : 'SHORT',
-                quantity: Math.abs(previousAmt),
-                pnl: 0, // Will be updated by ORDER_TRADE_UPDATE
-                reason: 'Position Closed',
-              });
-
-              // Also broadcast position_update with type closed for compatibility
+              // Broadcast position_update with type closed for compatibility
               this.statusBroadcaster.broadcastPositionUpdate({
                 symbol: symbol,
                 side: previousAmt > 0 ? 'LONG' : 'SHORT',