Skip to content

Commit b51fe72

Browse files
committed
fix(position-manager): ignore "would immediately trigger" batch errors
Filter "Order would immediately trigger" from batchResult.errors when handling batch order results. Only log and persist actual errors; still check presence of any errors to drive retry logic. This reduces noisy/expected errors in logs and the error DB while preserving correct retry behavior.
1 parent 391d1c5 commit b51fe72

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

src/lib/bot/positionManager.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1379,11 +1379,17 @@ export class PositionManager extends EventEmitter implements PositionTracker {
13791379
}
13801380

13811381
// Handle batch order results properly
1382-
if (batchResult.errors.length > 0) {
1383-
console.error(`PositionManager: Batch order errors for ${symbol}:`, batchResult.errors);
1382+
// Filter out expected "Order would immediately trigger" errors - these are handled by retry logic
1383+
const actualErrors = batchResult.errors.filter(
1384+
errorMsg => !errorMsg.includes('Order would immediately trigger')
1385+
);
1386+
1387+
// Log only actual errors (not expected "Order would immediately trigger" ones)
1388+
if (actualErrors.length > 0) {
1389+
console.error(`PositionManager: Batch order errors for ${symbol}:`, actualErrors);
13841390

1385-
// Log each error to the error database
1386-
for (const errorMsg of batchResult.errors) {
1391+
// Log each actual error to the error database
1392+
for (const errorMsg of actualErrors) {
13871393
await errorLogger.logTradingError(
13881394
'batchOrderPlacement',
13891395
symbol,
@@ -1406,7 +1412,10 @@ export class PositionManager extends EventEmitter implements PositionTracker {
14061412
}
14071413
);
14081414
}
1415+
}
14091416

1417+
// Check if there were ANY errors (including the filtered ones)
1418+
if (batchResult.errors.length > 0) {
14101419
// Determine what needs to be retried
14111420
const slFailed = placeSL && !batchResult.stopLoss;
14121421
const tpFailed = placeTP && !batchResult.takeProfit;

0 commit comments

Comments
 (0)