Skip to content

Commit 1cef76c

Browse files
committed
Renamed vars for ma_crossover indicator
1 parent f34bf7c commit 1cef76c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

app/analyzers/indicators/ma_crossover.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ def analyze(self, historical_data, signal=['close'], hot_thresh=None, cold_thres
3434
ma_slow_values = abstract.SMA(dataframe, ma_slow)
3535

3636
ma_crossover = pandas.concat([dataframe, ma_fast_values, ma_slow_values], axis=1)
37-
ma_crossover.rename(columns={0: 'ma_value_one', 1: 'ma_value_two'}, inplace=True)
37+
ma_crossover.rename(columns={0: 'fast_values', 1: 'slow_values'}, inplace=True)
3838

39-
o1, o2 = ma_crossover.iloc[-2]['ma_value_one'] , ma_crossover.iloc[-2]['ma_value_two']
40-
c1, c2 = ma_crossover.iloc[-1]['ma_value_one'] , ma_crossover.iloc[-1]['ma_value_two']
39+
previous_fast, previous_slow = ma_crossover.iloc[-2]['fast_values'] , ma_crossover.iloc[-2]['slow_values']
40+
current_fast, current_slow = ma_crossover.iloc[-1]['fast_values'] , ma_crossover.iloc[-1]['slow_values']
4141

4242
ma_crossover['is_hot'] = False
4343
ma_crossover['is_cold'] = False
4444

45-
ma_crossover['is_hot'].iloc[-1] = o1 < o2 and c1 > c2
46-
ma_crossover['is_cold'].iloc[-1] = o1 > o2 and c1 < c2
45+
ma_crossover['is_hot'].iloc[-1] = previous_fast < previous_slow and current_fast > current_slow
46+
ma_crossover['is_cold'].iloc[-1] = previous_fast > previous_slow and current_fast < current_slow
4747

4848
return ma_crossover

0 commit comments

Comments
 (0)