Skip to content

Commit 51d184e

Browse files
committed
Fix on charts creation due to ichimoku analyzer
1 parent a0a0b77 commit 51d184e

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed

app/analyzers/indicators/ichimoku.py

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -60,26 +60,27 @@ def analyze(self, historical_data, tenkansen_period, kijunsen_period, senkou_spa
6060
(ichimoku_values['tenkansen'] + ichimoku_values['kijunsen']) / 2)
6161
ichimoku_values['leading_span_b'] = (high_senkou + low_senkou) / 2
6262

63-
# add time period for cloud offset
64-
## if cloud discplacement changed the ichimuko plot will be off ##
65-
cloud_displacement = 26
66-
last_time = dataframe.index[-1]
67-
timedelta = dataframe.index[1] - dataframe.index[0]
68-
newindex = pandas.DatetimeIndex(start=last_time + timedelta,
69-
freq=timedelta,
70-
periods=cloud_displacement)
71-
ichimoku_values = ichimoku_values.append(
72-
pandas.DataFrame(index=newindex))
73-
# cloud offset
74-
ichimoku_values['leading_span_a'] = ichimoku_values['leading_span_a'].shift(
75-
cloud_displacement)
76-
ichimoku_values['leading_span_b'] = ichimoku_values['leading_span_b'].shift(
77-
cloud_displacement)
78-
7963
ichimoku_values['is_hot'] = False
8064
ichimoku_values['is_cold'] = False
8165

8266
try:
67+
# add time period for cloud offset
68+
## if cloud discplacement changed the ichimuko plot will be off ##
69+
cloud_displacement = 26
70+
last_time = dataframe.index[-1]
71+
timedelta = dataframe.index[1] - dataframe.index[0]
72+
newindex = pandas.DatetimeIndex(start=last_time + timedelta,
73+
freq=timedelta,
74+
periods=cloud_displacement)
75+
ichimoku_values = ichimoku_values.append(
76+
pandas.DataFrame(index=newindex))
77+
# cloud offset
78+
ichimoku_values['leading_span_a'] = ichimoku_values['leading_span_a'].shift(
79+
cloud_displacement)
80+
ichimoku_values['leading_span_b'] = ichimoku_values['leading_span_b'].shift(
81+
cloud_displacement)
82+
83+
8384
for index in range(0, ichimoku_values.index.shape[0]):
8485
date = ichimoku_values.index[index]
8586

@@ -97,8 +98,8 @@ def analyze(self, historical_data, tenkansen_period, kijunsen_period, senkou_spa
9798
else:
9899
pass
99100

100-
except KeyError as e:
101-
print('keyerror: {}'.format(e))
101+
except Exception as e:
102+
print('Error running ichimoku analysis: {}'.format(e))
102103

103104
if chart == None:
104105
ichimoku_values.dropna(how='any', inplace=True)

app/notification.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,10 @@ def notify_all_messages(self, exchange, market_pair, candle_period, messages):
164164
chart_file = self.create_chart(
165165
exchange, market_pair, candle_period, candles_data)
166166
#self.logger.info('Chart file %s', chart_file)
167-
except Exception:
167+
except Exception as e:
168168
self.logger.info('Error creating chart for %s %s',
169169
market_pair, candle_period)
170+
self.logger.exception(e)
170171

171172
# self.notify_slack(new_analysis)
172173
self.notify_discord(messages)
@@ -678,9 +679,10 @@ def create_charts(self, messages):
678679
try:
679680
self.create_chart(
680681
exchange, market_pair, candle_period, candles_data)
681-
except Exception:
682+
except Exception as e:
682683
self.logger.info(
683684
'Error creating chart for %s %s', market_pair, candle_period)
685+
self.logger.exception(e)
684686

685687
def create_chart(self, exchange, market_pair, candle_period, candles_data):
686688

0 commit comments

Comments
 (0)