Make constructors explicit

Most constructors were not marked as explicit. With many constructors
now taking a single Error object as argument this would allow them to be
implicitly created from an Error object. Since this would be confusing
we now mark the constructors as explicit.

The old behaviour can be restored by defining the preprocessor value
CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS.

Author: svedi

include/cryptolens/LicenseKeyChecker.hpp

@@ -13,6 +13,9 @@ class LicenseKeyChecker {
   LicenseKeyInformation const* key_;
 
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   LicenseKeyChecker(LicenseKeyInformation const* license_key);
 
   explicit operator bool() const;

include/cryptolens/MachineCodeComputer_COM.hpp

@@ -27,6 +27,9 @@ namespace MachineCodeComputer_COM_Recompute {}
 class MachineCodeComputer_COM_Recompute
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   MachineCodeComputer_COM_Recompute(basic_Error & e) {}
 
   std::string

include/cryptolens/MachineCodeComputer_caching.hpp

@@ -20,6 +20,9 @@ template<typename MachineCodeComputer>
 class MachineCodeComputer_caching
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   MachineCodeComputer_caching(basic_Error & e)
   : machine_code_()
   {

include/cryptolens/MachineCodeComputer_static.hpp

@@ -19,6 +19,9 @@ namespace MachineCodeComputer_static {}
 class MachineCodeComputer_static
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   MachineCodeComputer_static(basic_Error & e) {}
 
   void

include/cryptolens/RequestHandler_WinHTTP.hpp

@@ -61,6 +61,9 @@ class RequestHandler_WinHTTP_PostBuilder {
 class RequestHandler_WinHTTP
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   RequestHandler_WinHTTP(basic_Error & e);
 #ifndef CRYPTOLENS_ENABLE_DANGEROUS_COPY_MOVE_CONSTRUCTOR
   RequestHandler_WinHTTP(RequestHandler_WinHTTP const&) = delete;

include/cryptolens/RequestHandler_curl.hpp

@@ -58,6 +58,9 @@ class RequestHandler_curl_PostBuilder {
 class RequestHandler_curl
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   RequestHandler_curl(basic_Error & e);
 #ifndef CRYPTOLENS_ENABLE_DANGEROUS_COPY_MOVE_CONSTRUCTOR
   RequestHandler_curl(RequestHandler_curl const&) = delete;

include/cryptolens/RequestHandler_v20190401_to_v20180502.hpp

@@ -12,6 +12,9 @@ template<typename RequestHandler>
 class RequestHandler_v20190401_to_v20180502
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   RequestHandler_v20190401_to_v20180502();
 
   template<typename Map>

include/cryptolens/ResponseParser_ArduinoJson5.hpp

@@ -18,6 +18,9 @@ class ResponseParser_ArduinoJson5 {
  * a custom ResponseParser.
  */
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   ResponseParser_ArduinoJson5(basic_Error & e) {}
 
   optional<LicenseKeyInformation> make_license_key_information(basic_Error & e, RawLicenseKey const& raw_license_key) const;

include/cryptolens/SignatureVerifier_CryptoAPI.hpp

@@ -26,6 +26,9 @@ namespace v20190401 {
 class SignatureVerifier_CryptoAPI
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   SignatureVerifier_CryptoAPI(basic_Error & e);
 #ifndef CRYPTOLENS_ENABLE_DANGEROUS_COPY_MOVE_CONSTRUCTOR
   SignatureVerifier_CryptoAPI(SignatureVerifier_CryptoAPI const&) = delete;

include/cryptolens/SignatureVerifier_OpenSSL.hpp

@@ -25,6 +25,9 @@ namespace v20190401 {
 class SignatureVerifier_OpenSSL
 {
 public:
+#ifndef CRYPTOLENS_20190701_ALLOW_IMPLICIT_CONSTRUCTORS
+  explicit
+#endif
   SignatureVerifier_OpenSSL(basic_Error & e);
 #ifndef CRYPTOLENS_ENABLE_DANGEROUS_COPY_MOVE_CONSTRUCTOR
   SignatureVerifier_OpenSSL(SignatureVerifier_OpenSSL const&) = delete;