Skip to content

Commit e00f4aa

Browse files
committed
PR review changes
1 parent 92f79a5 commit e00f4aa

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ npm i puppeteer-page-proxy
2121
- `proxy` <[string](https://developer.mozilla.org/en-US/docs/Glossary/String)|[object](https://developer.mozilla.org/en-US/docs/Glossary/Object)> Proxy to use in the current page.
2222
* Begins with a protocol (e.g. http://, https://, socks://)
2323
* In the case of [proxy per request](https://github.com/Cuadrix/puppeteer-page-proxy#proxy-per-request), this can be an object with optional properties for overriding requests:\
24-
`url`, `method`, `postData`, `headers`, `ignoreInvalidCookies`\
24+
`url`, `method`, `postData`, `headers`\
2525
See [httpRequest.continue](https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#httprequestcontinueoverrides) for more info about the above properties.
2626

2727
#### PageProxy.lookup(page[, lookupService, isJSON, timeout])

src/core/proxy.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ const requestHandler = async (request, proxy, overrides = {}) => {
2020
responseType: "buffer",
2121
maxRedirects: 15,
2222
throwHttpErrors: false,
23-
ignoreInvalidCookies:
24-
typeof overrides.ignoreInvalidCookies === "undefined"
25-
? false
26-
: overrides.ignoreInvalidCookies,
23+
ignoreInvalidCookies: true,
2724
followRedirect: false
2825
};
2926
try {
@@ -42,7 +39,6 @@ const requestHandler = async (request, proxy, overrides = {}) => {
4239
});
4340
} catch (error) {
4441
await request.abort();
45-
throw error;
4642
}
4743
};
4844

0 commit comments

Comments
 (0)