Skip to content

Commit a9a30e1

Browse files
committed
feat: pass through additional Dockerfile env vars
1 parent 99c6e77 commit a9a30e1

File tree

6 files changed

+12
-0
lines changed

6 files changed

+12
-0
lines changed

python/3.10/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ FROM cubecoders/ampbase:debian
1717
LABEL org.opencontainers.image.licenses=MIT
1818

1919
ENV PIP_DISABLE_PIP_VERSION_CHECK="1"
20+
ENV AMP_ADDITIONAL_ENV_VARS="PIP_DISABLE_PIP_VERSION_CHECK"
2021
ENV DEBIAN_FRONTEND="noninteractive"
2122

2223
ARG PYTHON_VERSION="3.10"

python/3.11/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ FROM cubecoders/ampbase:debian
1717
LABEL org.opencontainers.image.licenses=MIT
1818

1919
ENV PIP_DISABLE_PIP_VERSION_CHECK="1"
20+
ENV AMP_ADDITIONAL_ENV_VARS="PIP_DISABLE_PIP_VERSION_CHECK"
2021
ENV DEBIAN_FRONTEND="noninteractive"
2122

2223
ARG PYTHON_VERSION="3.11"

python/3.12/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ FROM cubecoders/ampbase:debian
1717
LABEL org.opencontainers.image.licenses=MIT
1818

1919
ENV PIP_DISABLE_PIP_VERSION_CHECK="1"
20+
ENV AMP_ADDITIONAL_ENV_VARS="PIP_DISABLE_PIP_VERSION_CHECK"
2021
ENV DEBIAN_FRONTEND="noninteractive"
2122

2223
ARG PYTHON_VERSION="3.12"

python/3.13/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ FROM cubecoders/ampbase:debian
1717
LABEL org.opencontainers.image.licenses=MIT
1818

1919
ENV PIP_DISABLE_PIP_VERSION_CHECK="1"
20+
ENV AMP_ADDITIONAL_ENV_VARS="PIP_DISABLE_PIP_VERSION_CHECK"
2021
ENV DEBIAN_FRONTEND="noninteractive"
2122

2223
ARG PYTHON_VERSION="3.13"

python/3/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ FROM cubecoders/ampbase:debian
5353
LABEL org.opencontainers.image.licenses=MIT
5454

5555
ENV PIP_DISABLE_PIP_VERSION_CHECK="1"
56+
ENV AMP_ADDITIONAL_ENV_VARS="PIP_DISABLE_PIP_VERSION_CHECK"
5657
ENV DEBIAN_FRONTEND="noninteractive"
5758

5859
ARG PYTHON_DEFAULT="3.11"

scripts/base/ampstart.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,16 @@ keep_env=(
9696
PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
9797
MAIL=/var/mail/amp
9898
)
99+
# Always keep these AMP_ env vars if set
99100
for v in AMPHOSTPLATFORM AMP_CONTAINER AMP_CONTAINER_HOST_NETWORK AMPMEMORYLIMIT AMPSWAPLIMIT AMPCONTAINERCPUS; do
100101
if [[ -n "${!v-}" ]]; then keep_env+=("$v=${!v}"); fi
101102
done
103+
# Extra passthrough of env vars listed in AMP_ADDITIONAL_ENV_VARS in the Dockerfile
104+
if [[ -n "${AMP_ADDITIONAL_ENV_VARS-}" ]]; then
105+
for v in ${AMP_ADDITIONAL_ENV_VARS}; do
106+
if [[ -n "${!v-}" ]]; then keep_env+=("$v=${!v}"); fi
107+
done
108+
fi
102109

103110
exec gosu amp:amp env -i "${keep_env[@]}" \
104111
bash -c "cd /AMP && exec ${AMP_BIN} ${ARGS}"

0 commit comments

Comments
 (0)