fix: Force HTTP/1.1 on non Hetzner hosts

- Fixes a test having issues likely due to HTTP/2

Author: CubitsDev

src/main/java/dev/tomr/hcloud/HetznerCloud.java

@@ -115,4 +115,12 @@ public boolean hasApiKey() {
     public Server getServer(Integer id) {
         return serviceManager.getServerService().getServer(id);
     }
+
+    /**
+     * Returns the HETZNER_CLOUD_HOST constant
+     * @return String with the hetzner cloud host
+     */
+    public static String getHetznerCloudHost() {
+        return HETZNER_CLOUD_HOST;
+    }
 }

src/main/java/dev/tomr/hcloud/http/HetznerCloudHttpClient.java

@@ -88,8 +88,15 @@ public <T extends HetznerJsonObject> T sendHttpRequest(Class<T> clazz, String en
     }
 
     private HttpRequest createHttpRequest(String uri, RequestVerb requestVerb, String apiKey, String body) {
+        // wiremock seems to have problems with using HTTP/2 sometimes (seems like a bug in the http client) - therefore if we know it's Hetzner,
+        // we'll enforce HTTP/2 - otherwise HTTP/1.1
+        HttpClient.Version version = HttpClient.Version.HTTP_1_1;
+        if (HetznerCloud.getInstance().getHttpDetails().get(0).equals(HetznerCloud.getHetznerCloudHost())) {
+            version = HttpClient.Version.HTTP_2;
+        }
         HttpRequest.Builder builder = HttpRequest.newBuilder()
                 .uri(URI.create(uri))
+                .version(version)
                 .header("Authorization", format("Bearer %s", apiKey))
                 .header("Content-Type", "application/json");
         builder = switch (requestVerb) {

src/test/java/dev/tomr/hcloud/component/http/HttpClientComponentTest.java

@@ -1,11 +1,13 @@
 package dev.tomr.hcloud.component.http;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.github.tomakehurst.wiremock.client.ResponseDefinitionBuilder;
 import com.github.tomakehurst.wiremock.common.Notifier;
 import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
 import com.github.tomakehurst.wiremock.junit5.WireMockRuntimeInfo;
 import com.github.tomakehurst.wiremock.junit5.WireMockTest;
+import dev.tomr.hcloud.HetznerCloud;
 import dev.tomr.hcloud.http.HetznerCloudHttpClient;
 import dev.tomr.hcloud.http.RequestVerb;
 import dev.tomr.hcloud.http.exception.HetznerApiException;
@@ -14,12 +16,15 @@
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
+import org.mockito.MockedStatic;
 
 import java.io.IOException;
+import java.util.List;
 
 import static com.github.tomakehurst.wiremock.client.WireMock.*;
 import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.wireMockConfig;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.*;
 
 public class HttpClientComponentTest {
 
@@ -99,15 +104,7 @@ void testHttpClientThrowsBadResponseGracefully() {
 
         HetznerApiException hetznerApiException = assertThrows(
                 HetznerApiException.class,
-                () -> {
-                    try {
-                        client.sendHttpRequest(TestModel.class, HOST + "badResponse", RequestVerb.GET, "");
-                    } catch (Exception e) {
-                        System.out.println(e.getMessage());
-                        e.printStackTrace();
-                        throw e;
-                    }
-                }
+                () -> client.sendHttpRequest(TestModel.class, HOST + "badResponse", RequestVerb.GET, "")
         );
 
         assertEquals("HetznerErrorResponse [code=uniqueness_error, message=SSH key with the same fingerprint already exists]", hetznerApiException.getMessage());
@@ -124,12 +121,33 @@ void testHttpClientThrowsHetznerApiExceptionWhenBadJsonResponse() {
 
     @Test
     @DisplayName("HTTP Client handles 204 no content correctly")
-    void httpClientHandles204NoContent() throws IOException, InterruptedException, IllegalAccessException {
+    void httpClientHandles204NoContent() {
         // this test is needed because 204 does not support handling a body
         // todo refactor how we handle HTTP Status codes we **know** will never supply a body, i.e. 204 - this implementation leaves a lot to be desired
         wireMockExtension.stubFor(get("/test").willReturn(aResponse().withStatus(204)));
         HetznerCloudHttpClient client = new HetznerCloudHttpClient();
 
         assertDoesNotThrow(() -> client.sendHttpRequest(TestModel.class, HOST + "test", RequestVerb.GET, ""));
     }
+
+    @Test
+    @DisplayName("Request uses HTTP/2 when targeting Hetzner, instead of HTTP/1.1 by default")
+    void requestUsesHttp2WhenTargetingHetznerHost() throws IOException, InterruptedException, IllegalAccessException {
+        wireMockExtension.stubFor(get("/test").willReturn(ok(objectMapper.writeValueAsString(new TestModel(1, 1, "sunt aut facere repellat provident occaecati excepturi optio reprehenderit", "quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto")))));
+        HetznerCloud hetznerCloud = mock(HetznerCloud.class);
+        try (MockedStatic<HetznerCloud> hetznerCloudMockedStatic = mockStatic(HetznerCloud.class)) {
+            hetznerCloudMockedStatic.when(HetznerCloud::getHetznerCloudHost).thenReturn(HOST);
+            hetznerCloudMockedStatic.when(HetznerCloud::getInstance).thenReturn(hetznerCloud);
+            when(hetznerCloud.getHttpDetails()).thenReturn(List.of(HOST, ""));
+
+            HetznerCloudHttpClient client = new HetznerCloudHttpClient();
+
+            TestModel testModel = client.sendHttpRequest(TestModel.class, HOST + "test", RequestVerb.GET, "");
+
+            assertEquals(1, testModel.getId());
+            assertEquals(1, testModel.getUserId());
+            assertEquals("sunt aut facere repellat provident occaecati excepturi optio reprehenderit", testModel.getTitle());
+            assertEquals("quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto", testModel.getBody());
+        }
+    }
 }